Skip to content

Commit 7e31279

Browse files
montywivuvova
authored andcommitted
Speed up some innodb tests
Fixed compiler warnings sql/sql_view.cc: Ensure that merged_for_insert is properly reset (Left of an old patch)
1 parent b2b07b3 commit 7e31279

File tree

7 files changed

+25
-2
lines changed

7 files changed

+25
-2
lines changed

mysql-test/suite/innodb/include/innodb_simulate_comp_failures.inc

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ SET GLOBAL innodb_simulate_comp_failures = 25;
3030
--disable_result_log
3131

3232
let $num_inserts_ind = $num_inserts;
33+
let $commit_iterations=50;
34+
3335
while ($num_inserts_ind)
3436
{
3537
let $repeat = `select floor(rand() * 10)`;
@@ -49,6 +51,9 @@ SELECT COUNT(*) FROM t1;
4951

5052
# do random ops, making sure that some pages will get fragmented and reorganized.
5153
let $num_ops_ind = $num_ops;
54+
let $commit_count= $commit_iterations;
55+
56+
BEGIN;
5257

5358
while($num_ops_ind)
5459
{
@@ -133,9 +138,19 @@ while($num_ops_ind)
133138
}
134139
}
135140

141+
dec $commit_count;
142+
if (!$commit_count)
143+
{
144+
let $commit_count= $commit_iterations;
145+
COMMIT;
146+
BEGIN;
147+
}
148+
136149
dec $num_ops_ind;
137150
}
138151

152+
COMMIT;
153+
139154
# final cleanup
140155
DROP TABLE t1;
141156

mysql-test/suite/innodb/r/innodb-bigblob.result

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
call mtr.add_suppression("Resizing redo log from *");
22
call mtr.add_suppression("Starting to delete and rewrite log files.");
33
call mtr.add_suppression("New log files created, LSN=*");
4+
call mtr.add_suppression("Writer thread is waiting this semaphore");
45
create table foo (id varchar(37) not null, content longblob) engine=INNODB;
56
insert into foo (id, content) values('xyz', '');
67
update foo set content=repeat('a', 43941888) where id='xyz';
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
--max-allowed-packet=128M
22
--innodb-log-file-size=210M
3+
--skip-innodb-doublewrite

mysql-test/suite/innodb/t/innodb-bigblob.test

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ let $status_orig=`SELECT @@innodb_status_output`;
99
call mtr.add_suppression("Resizing redo log from *");
1010
call mtr.add_suppression("Starting to delete and rewrite log files.");
1111
call mtr.add_suppression("New log files created, LSN=*");
12+
call mtr.add_suppression("Writer thread is waiting this semaphore");
1213

1314
create table foo (id varchar(37) not null, content longblob) engine=INNODB;
1415
insert into foo (id, content) values('xyz', '');
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
--innodb-file-per-table
2-
2+
--skip-innodb-doublewrite

sql/sql_view.cc

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1283,6 +1283,11 @@ bool mysql_make_view(THD *thd, TABLE_SHARE *share, TABLE_LIST *table,
12831283
*/
12841284
table->open_type= OT_BASE_ONLY;
12851285

1286+
/*
1287+
Clear old variables in the TABLE_LIST that could be left from an old view
1288+
*/
1289+
table->merged_for_insert= FALSE;
1290+
12861291
/*TODO: md5 test here and warning if it is differ */
12871292

12881293

storage/mroonga/vendor/groonga/lib/operator.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,7 @@ grn_operator_exec_equal(grn_ctx *ctx, grn_obj *x, grn_obj *y)
352352
grn_bool
353353
grn_operator_exec_not_equal(grn_ctx *ctx, grn_obj *x, grn_obj *y)
354354
{
355-
grn_bool r;
355+
grn_bool r= 0;
356356
GRN_API_ENTER;
357357
DO_EQ(x, y, r);
358358
GRN_API_RETURN(!r);

0 commit comments

Comments
 (0)