MDEV-36104 Server crashes when reading information_schema.COLUMNS after creating a table with virtual columns using the GIS data type

allow the table to be opened in any sql_mode, so that it can be examined (show create) and alter'ed to correct the error. the type mismatch error will be issued on DMLs and on CREATE, but not on SHOW or ALTER

Author: vuvova

mysql-test/main/create.result

@@ -2129,3 +2129,32 @@ EXECUTE stmt USING 4;
 ERROR 22007: Truncated incorrect DECIMAL value: ''
 DROP TABLE t;
 # End of 11.7 Test
+#
+# MDEV-36104 Server crashes when reading information_schema.COLUMNS after creating a table with virtual columns using the GIS data type
+#
+create table t (a point generated always as (1) stored,b int generated always as (1) virtual);
+ERROR HY000: Cannot cast 'int' as 'point' in assignment of `test`.`t`.`a`
+set sql_mode='';
+create table t (a point generated always as (1) stored,b int generated always as (1) virtual);
+Warnings:
+Warning	4078	Cannot cast 'int' as 'point' in assignment of `test`.`t`.`a`
+set sql_mode=default;
+select column_name,column_type from information_schema.columns where table_name='t';
+column_name	column_type
+a	point
+b	int(11)
+Warnings:
+Warning	4078	Cannot cast 'int' as 'point' in assignment of `test`.`t`.`a`
+show create table t;
+Table	Create Table
+t	CREATE TABLE `t` (
+ `a` point GENERATED ALWAYS AS (1) STORED,
+ `b` int(11) GENERATED ALWAYS AS (1) VIRTUAL
+) ENGINE=MyISAM DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_uca1400_ai_ci
+Warnings:
+Warning	4078	Cannot cast 'int' as 'point' in assignment of `test`.`t`.`a`
+insert t () values ();
+ERROR 22003: Cannot get geometry object from data you send to the GEOMETRY field
+alter table t add column c int, drop column a, drop column b;
+drop table t;
+# End of 11.8 Test

mysql-test/main/create.test

@@ -2002,3 +2002,22 @@ EXECUTE stmt USING 4;
 DROP TABLE t;
 
 --echo # End of 11.7 Test
+
+--echo #
+--echo # MDEV-36104 Server crashes when reading information_schema.COLUMNS after creating a table with virtual columns using the GIS data type
+--echo #
+--error ER_ILLEGAL_PARAMETER_DATA_TYPES2_FOR_OPERATION
+create table t (a point generated always as (1) stored,b int generated always as (1) virtual);
+set sql_mode='';
+create table t (a point generated always as (1) stored,b int generated always as (1) virtual);
+set sql_mode=default;
+select column_name,column_type from information_schema.columns where table_name='t';
+--enable_prepare_warnings
+show create table t;
+--disable_prepare_warnings
+--error ER_CANT_CREATE_GEOMETRY_OBJECT
+insert t () values ();
+alter table t add column c int, drop column a, drop column b;
+drop table t;
+
+--echo # End of 11.8 Test

sql/table.cc

@@ -1260,7 +1260,8 @@ bool parse_vcol_defs(THD *thd, MEM_ROOT *mem_root, TABLE *table,
  table->map= 1;
  if (vcol &&
  (field_ptr[0]->check_vcol_sql_mode_dependency(thd, mode) ||
- vcol->expr->check_assignability_to(field_ptr[0], false)))
+ vcol->expr->check_assignability_to(field_ptr[0],
+ mode == VCOL_INIT_DEPENDENCY_FAILURE_IS_WARNING)))
  {
  DBUG_ASSERT(thd->is_error());
  *error_reported= true;