Skip to content

Commit 17c9ed6

Browse files
committed
Fix perfschema tests in debug mode.
Correctly initialize fake IPs.
1 parent e3cf577 commit 17c9ed6

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

sql/hostname.cc

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -701,11 +701,13 @@ int ip_to_hostname(struct sockaddr_storage *ip_storage,
701701
static struct addrinfo debug_addr_info[2];
702702
/* Simulating ipv4 192.0.2.126 */
703703
debug_addr= & debug_sock_addr[0];
704-
inet_pton(AF_INET,"192.0.2.126",debug_addr);
704+
debug_addr->sin_family= AF_INET;
705+
inet_pton(AF_INET,"192.0.2.126", &debug_addr->sin_addr);
705706

706707
/* Simulating ipv4 192.0.2.127 */
707708
debug_addr= & debug_sock_addr[1];
708-
inet_pton(AF_INET,"192.0.2.127",debug_addr);
709+
debug_addr->sin_family= AF_INET;
710+
inet_pton(AF_INET,"192.0.2.127", &debug_addr->sin_addr);
709711

710712
debug_addr_info[0].ai_addr= (struct sockaddr*) & debug_sock_addr[0];
711713
debug_addr_info[0].ai_addrlen= sizeof (struct sockaddr_in);
@@ -731,11 +733,13 @@ int ip_to_hostname(struct sockaddr_storage *ip_storage,
731733
static struct addrinfo debug_addr_info[2];
732734
/* Simulating ipv4 192.0.2.5 */
733735
debug_addr= & debug_sock_addr[0];
734-
inet_pton(AF_INET,"192.0.2.5",debug_addr);
736+
debug_addr->sin_family= AF_INET;
737+
inet_pton(AF_INET,"192.0.2.5", &debug_addr->sin_addr);
735738

736739
/* Simulating ipv4 192.0.2.4 */
737740
debug_addr= & debug_sock_addr[1];
738-
inet_pton(AF_INET,"192.0.2.5",debug_addr);
741+
debug_addr->sin_family= AF_INET;
742+
inet_pton(AF_INET,"192.0.2.4", &debug_addr->sin_addr);
739743

740744
debug_addr_info[0].ai_addr= (struct sockaddr*) & debug_sock_addr[0];
741745
debug_addr_info[0].ai_addrlen= sizeof (struct sockaddr_in);
@@ -768,13 +772,16 @@ int ip_to_hostname(struct sockaddr_storage *ip_storage,
768772
static struct addrinfo debug_addr_info[2];
769773
/* Simulating ipv6 2001:DB8::6:7E */
770774
debug_addr= & debug_sock_addr[0];
775+
debug_addr->sin6_family= AF_INET6;
771776
ip6= & debug_addr->sin6_addr;
772777
inet_pton(AF_INET6,"2001:DB8::6:7E",ip6);
773778

774779
/* Simulating ipv6 2001:DB8::6:7F */
775780
debug_addr= & debug_sock_addr[1];
781+
debug_addr->sin6_family= AF_INET6;
776782
ip6= & debug_addr->sin6_addr;
777-
inet_pton(AF_INET6,"2001:DB8::6:7E",ip6);
783+
inet_pton(AF_INET6,"2001:DB8::6:7F",ip6);
784+
778785
debug_addr_info[0].ai_addr= (struct sockaddr*) & debug_sock_addr[0];
779786
debug_addr_info[0].ai_addrlen= sizeof (struct sockaddr_in6);
780787
debug_addr_info[0].ai_next= & debug_addr_info[1];

sql/sql_connect.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -979,7 +979,7 @@ static int check_connection(THD *thd)
979979
struct in_addr *ip4= &((struct sockaddr_in *) sa)->sin_addr;
980980
/* See RFC 5737, 192.0.2.0/24 is reserved. */
981981
const char* fake= "192.0.2.4";
982-
inet_pton(AF_INET,fake, &ip4);
982+
inet_pton(AF_INET,fake, ip4);
983983
strcpy(ip, fake);
984984
peer_rc= 0;
985985
}

0 commit comments

Comments
 (0)