Skip to content

Commit 0001049

Browse files
committed
MDEV-12276 Missing DBUG_RETURN or DBUG_VOID_RETURN macro in function "do_exec"
1 parent 036b689 commit 0001049

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

client/mysqltest.cc

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1038,7 +1038,7 @@ void do_eval(DYNAMIC_STRING *query_eval, const char *query,
10381038
if (!(v= var_get(p, &p, 0, 0)))
10391039
{
10401040
report_or_die( "Bad variable in eval");
1041-
return;
1041+
DBUG_VOID_RETURN;
10421042
}
10431043
dynstr_append_mem(query_eval, v->str_val, v->str_val_len);
10441044
}
@@ -1753,7 +1753,7 @@ static int run_command(char* cmd,
17531753
if (!(res_file= popen(cmd, "r")))
17541754
{
17551755
report_or_die("popen(\"%s\", \"r\") failed", cmd);
1756-
return -1;
1756+
DBUG_RETURN(-1);
17571757
}
17581758

17591759
while (fgets(buf, sizeof(buf), res_file))
@@ -2661,7 +2661,7 @@ void var_query_set(VAR *var, const char *query, const char** query_end)
26612661
report_or_die("Query '%s' didn't return a result set", ds_query.str);
26622662
dynstr_free(&ds_query);
26632663
eval_expr(var, "", 0);
2664-
return;
2664+
DBUG_VOID_RETURN;
26652665
}
26662666
dynstr_free(&ds_query);
26672667

@@ -2852,7 +2852,7 @@ void var_set_query_get_value(struct st_command *command, VAR *var)
28522852
dynstr_free(&ds_query);
28532853
dynstr_free(&ds_col);
28542854
eval_expr(var, "", 0);
2855-
return;
2855+
DBUG_VOID_RETURN;
28562856
}
28572857

28582858
{
@@ -2877,7 +2877,7 @@ void var_set_query_get_value(struct st_command *command, VAR *var)
28772877
ds_col.str, ds_query.str);
28782878
dynstr_free(&ds_query);
28792879
dynstr_free(&ds_col);
2880-
return;
2880+
DBUG_VOID_RETURN;
28812881
}
28822882
DBUG_PRINT("info", ("Found column %d with name '%s'",
28832883
i, fields[i].name));
@@ -3323,7 +3323,7 @@ void do_exec(struct st_command *command)
33233323
if (!*cmd)
33243324
{
33253325
report_or_die("Missing argument in exec");
3326-
return;
3326+
DBUG_VOID_RETURN;
33273327
}
33283328
command->last_argument= command->end;
33293329

@@ -3357,7 +3357,7 @@ void do_exec(struct st_command *command)
33573357
dynstr_free(&ds_cmd);
33583358
if (command->abort_on_error)
33593359
report_or_die("popen(\"%s\", \"r\") failed", command->first_argument);
3360-
return;
3360+
DBUG_VOID_RETURN;
33613361
}
33623362

33633363
ds_result= &ds_res;
@@ -3415,7 +3415,7 @@ void do_exec(struct st_command *command)
34153415
ds_cmd.str, error, status, errno,
34163416
ds_res.str);
34173417
dynstr_free(&ds_cmd);
3418-
return;
3418+
DBUG_VOID_RETURN;
34193419
}
34203420

34213421
DBUG_PRINT("info",
@@ -3547,7 +3547,7 @@ void do_system(struct st_command *command)
35473547
if (strlen(command->first_argument) == 0)
35483548
{
35493549
report_or_die("Missing arguments to system, nothing to do!");
3550-
return;
3550+
DBUG_VOID_RETURN;
35513551
}
35523552

35533553
init_dynamic_string(&ds_cmd, 0, command->query_len + 64, 256);
@@ -4540,7 +4540,7 @@ void do_perl(struct st_command *command)
45404540
if (command->abort_on_error)
45414541
die("popen(\"%s\", \"r\") failed", buf);
45424542
dynstr_free(&ds_delimiter);
4543-
return;
4543+
DBUG_VOID_RETURN;
45444544
}
45454545

45464546
while (fgets(buf, sizeof(buf), res_file))

0 commit comments

Comments
 (0)