ci(lint): Fix linting

Author: ht2

lib/helpers/getDateFromMongoID.js

@@ -1,15 +1,18 @@
-import isString  from 'lodash/isString';
+import isString from 'lodash/isString';
 
-export default _id => {
- if (!isString(_id) || _id.length != 24) {
+export default (_id) => {
+ if (!isString(_id) || _id.length !== 24) {
  // not a mongo id
  throw Error('Not a Mongo ID');
  }
- const timehex = _id.substring(0,8);
+ const timehex = _id.substring(0, 8);
 
  // convert to a number... base 16
  const secondsSinceEpoch = parseInt(timehex, 16);
+ if (isNaN(secondsSinceEpoch)) {
+ throw Error('Invalid date in Mongo ID');
+ }
 
  // convert to milliseconds, and create a new date
- return new Date(secondsSinceEpoch*1000);
-}
+ return new Date(secondsSinceEpoch * 1000);
+};

lib/helpers/tests/getDateFromMongoID-test.js

@@ -2,10 +2,10 @@ import { expect } from 'chai';
 import getDateFromMongoID from '../getDateFromMongoID';
 
 const _id = '5ad52af00000000000000000';
-describe.only('getDateFromMongoID', () => {
+describe('getDateFromMongoID', () => {
  it('should return date for Mongo ID as string', () => {
  const date = getDateFromMongoID(_id);
- const expectedDate = new Date("2018-04-16T23:00:00");
+ const expectedDate = new Date('2018-04-16T23:00:00');
  expect(date.getTime()).to.equal(expectedDate.getTime());
  });
 
@@ -23,4 +23,7 @@ describe.only('getDateFromMongoID', () => {
  expect(getDateFromMongoID.bind(null, `${_id}0`)).to.throw(Error);
  });
 
+ it('should error when _id does not contain a valid hex date', () => {
+ expect(getDateFromMongoID.bind(null, 'Zad52af00000000000000000')).to.throw(Error);
+ });
 });

ui/src/containers/Owner/CreatedAt.js

@@ -1,6 +1,6 @@
 import moment from 'moment';
 
-export default createdAt => {
+export default (createdAt) => {
  if (!createdAt) return '';
  return `Created ${moment(createdAt).fromNow()} - ${moment(createdAt).format('YYYY-MM-DD HH:mm:ss')}`;
-}
+};

ui/src/containers/Owner/index.js

@@ -14,7 +14,7 @@ const getCreatedDate = (createdAt, _id) => {
  }
  }
  return createdAt;
-}
+};
 
 const Creator = compose(
  withProps(({ model }) => ({ schema: 'user', id: model.get('owner') })),
@@ -35,7 +35,7 @@ export default ({ model }) => {
  const formattedDate = createdAtFormatter(date);
  return (
  model.has('owner')
- ? <Creator model={model} date={ formattedDate } />
+ ? <Creator model={model} date={formattedDate} />
  : <div style={{ marginTop: 8 }}>{ formattedDate }</div>
- )
+ );
 };