Skip to content

Commit a1996af

Browse files
committed
[Java] Property formatting.
1 parent dd7521f commit a1996af

File tree

1 file changed

+14
-12
lines changed

1 file changed

+14
-12
lines changed

sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/java/JavaGenerator.java

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1627,14 +1627,15 @@ private CharSequence generatePrimitiveFieldMetaData(
16271627

16281628
final PrimitiveType primitiveType = token.encoding().primitiveType();
16291629
final String javaTypeName = javaTypeName(primitiveType);
1630+
final String formattedPropertyName = formatPropertyName(propertyName);
16301631

16311632
sb.append(String.format("\n" +
16321633
indent + " public static %s %sNullValue()\n" +
16331634
indent + " {\n" +
16341635
indent + " return %s;\n" +
16351636
indent + " }\n",
16361637
javaTypeName,
1637-
propertyName,
1638+
formattedPropertyName,
16381639
generateLiteral(primitiveType, token.encoding().applicableNullValue().toString())));
16391640

16401641
sb.append(String.format("\n" +
@@ -1643,7 +1644,7 @@ private CharSequence generatePrimitiveFieldMetaData(
16431644
indent + " return %s;\n" +
16441645
indent + " }\n",
16451646
javaTypeName,
1646-
propertyName,
1647+
formattedPropertyName,
16471648
generateLiteral(primitiveType, token.encoding().applicableMinValue().toString())));
16481649

16491650
sb.append(String.format(
@@ -1653,7 +1654,7 @@ private CharSequence generatePrimitiveFieldMetaData(
16531654
indent + " return %s;\n" +
16541655
indent + " }\n",
16551656
javaTypeName,
1656-
propertyName,
1657+
formattedPropertyName,
16571658
generateLiteral(primitiveType, token.encoding().applicableMaxValue().toString())));
16581659

16591660
return sb;
@@ -1680,7 +1681,7 @@ private CharSequence generatePrimitivePropertyDecode(
16801681
indent + " return %s;\n" +
16811682
indent + " }\n\n",
16821683
javaTypeName,
1683-
propertyName,
1684+
formatPropertyName(propertyName),
16841685
generateFieldNotPresentCondition(inComposite, propertyToken.version(), encoding, indent),
16851686
generateGet(encoding.primitiveType(), "offset + " + offset, byteOrderStr));
16861687
}
@@ -1701,7 +1702,7 @@ private CharSequence generatePrimitivePropertyEncode(
17011702
indent + " return this;\n" +
17021703
indent + " }\n\n",
17031704
formatClassName(containingClassName),
1704-
propertyName,
1705+
formatPropertyName(propertyName),
17051706
javaTypeName,
17061707
generatePut(encoding.primitiveType(), "offset + " + offset, "value", byteOrderStr));
17071708
}
@@ -1859,7 +1860,7 @@ private CharSequence generatePrimitiveArrayPropertyDecode(
18591860
indent + " for (; end < %d && dst[end] != 0; ++end);\n\n" +
18601861
indent + " return new String(dst, 0, end, %s);\n" +
18611862
indent + " }\n\n",
1862-
formatPropertyName(propertyName),
1863+
propertyName,
18631864
generateStringNotPresentCondition(propertyToken.version(), indent),
18641865
fieldLength, offset,
18651866
fieldLength, fieldLength,
@@ -1905,7 +1906,7 @@ private static void generateArrayLengthMethod(
19051906
indent + " {\n" +
19061907
indent + " return %d;\n" +
19071908
indent + " }\n\n",
1908-
propertyName,
1909+
formatPropertyName(propertyName),
19091910
fieldLength));
19101911
}
19111912

@@ -2083,6 +2084,7 @@ private static void generateCharacterEncodingMethod(
20832084
private CharSequence generateConstPropertyMethods(
20842085
final String propertyName, final Token token, final String indent)
20852086
{
2087+
final String formattedPropertyName = formatPropertyName(propertyName);
20862088
final Encoding encoding = token.encoding();
20872089
if (encoding.primitiveType() != PrimitiveType.CHAR)
20882090
{
@@ -2092,7 +2094,7 @@ private CharSequence generateConstPropertyMethods(
20922094
indent + " return %s;\n" +
20932095
indent + " }\n",
20942096
javaTypeName(encoding.primitiveType()),
2095-
propertyName,
2097+
formattedPropertyName,
20962098
generateLiteral(encoding.primitiveType(), encoding.constValue().toString()));
20972099
}
20982100

@@ -2109,15 +2111,15 @@ private CharSequence generateConstPropertyMethods(
21092111
propertyName.toUpperCase(),
21102112
values));
21112113

2112-
generateArrayLengthMethod(propertyName, indent, constBytes.length, sb);
2114+
generateArrayLengthMethod(formattedPropertyName, indent, constBytes.length, sb);
21132115

21142116
sb.append(String.format(
21152117
indent + " public %s %s(final int index)\n" +
21162118
indent + " {\n" +
21172119
indent + " return %s_VALUE[index];\n" +
21182120
indent + " }\n\n",
21192121
javaTypeName,
2120-
propertyName,
2122+
formattedPropertyName,
21212123
propertyName.toUpperCase()));
21222124

21232125
sb.append(String.format(
@@ -2138,7 +2140,7 @@ private CharSequence generateConstPropertyMethods(
21382140
indent + " {\n" +
21392141
indent + " return \"%s\";\n" +
21402142
indent + " }\n\n",
2141-
propertyName,
2143+
formattedPropertyName,
21422144
encoding.constValue()));
21432145
}
21442146
else
@@ -2148,7 +2150,7 @@ private CharSequence generateConstPropertyMethods(
21482150
indent + " {\n" +
21492151
indent + " return (byte)%s;\n" +
21502152
indent + " }\n\n",
2151-
propertyName,
2153+
formattedPropertyName,
21522154
encoding.constValue()));
21532155
}
21542156

0 commit comments

Comments
 (0)