Skip to content

Commit 1369028

Browse files
committed
silently disable raw mode to fix the stdin reading blocking
1 parent 6ea8790 commit 1369028

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

cpp-terminal/private/platform.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,8 @@ Term::Private::BaseTerminal::~BaseTerminal() noexcept(false) {
146146
Term::Private::BaseTerminal::BaseTerminal(bool enable_keyboard,
147147
bool /*disable_ctrl_c*/)
148148
: keyboard_enabled{enable_keyboard} {
149-
// Uncomment this to silently disable raw mode for non-tty
150-
// if (keyboard_enabled) keyboard_enabled = is_stdin_a_tty();
149+
// silently disable raw mode for non-tty
150+
if (keyboard_enabled) keyboard_enabled = is_stdin_a_tty();
151151
out_console = is_stdout_a_tty();
152152
if (out_console) {
153153
hout = GetStdHandle(STD_OUTPUT_HANDLE);
@@ -189,8 +189,8 @@ Term::Private::BaseTerminal::BaseTerminal(bool enable_keyboard,
189189
bool disable_ctrl_c)
190190
: orig_termios{std::make_unique<termios>()},
191191
keyboard_enabled{enable_keyboard} {
192-
// Uncomment this to silently disable raw mode for non-tty
193-
// if (keyboard_enabled) keyboard_enabled = is_stdin_a_tty();
192+
// silently disable raw mode for non-tty
193+
if (keyboard_enabled) keyboard_enabled = is_stdin_a_tty();
194194
if (keyboard_enabled) {
195195
if (tcgetattr(STDIN_FILENO, orig_termios.get()) == -1) {
196196
throw std::runtime_error("tcgetattr() failed");

0 commit comments

Comments
 (0)