code cleanup

Author: juan-medina

src/main/kotlin/org/learning/by/example/reactive/kotlin/microservices/KotlinReactiveMS/application/ApplicationConfig.kt

@@ -42,6 +42,6 @@ internal class ApplicationConfig {
  = GeoLocationServiceImpl(endPoint)
 
  @Bean
- internal fun gunriseSunsetService(@Value("\${SunriseSunsetServiceImpl.endPoint}") endPoint: String): SunriseSunsetService
+ internal fun sunriseSunsetService(@Value("\${SunriseSunsetServiceImpl.endPoint}") endPoint: String): SunriseSunsetService
  = SunriseSunsetServiceImpl(endPoint)
 }

src/test/kotlin/org/learning/by/example/reactive/kotlin/microservices/KotlinReactiveMS/application/KotlinReactiveMsApplicationTests.kt

@@ -28,7 +28,7 @@ private class KotlinReactiveMsApplicationTests : BasicIntegrationTest() {
 
  @Test
  fun getLocation() {
- val locationResponse: LocationResponse = get(url = "${API_LOCATION}/${GOOGLE_ADDRESS}")
+ val locationResponse: LocationResponse = get(url = "$API_LOCATION/$GOOGLE_ADDRESS")
  locationResponse.geographicCoordinates `should not be` null
  }
 

src/test/kotlin/org/learning/by/example/reactive/kotlin/microservices/KotlinReactiveMS/routers/ApiRouterTest.kt

@@ -56,7 +56,7 @@ private class ApiRouterTest : BasicIntegrationTest() {
  (geoLocationService `will return` GOOGLE_LOCATION_MONO).fromAddress(any())
  (sunriseSunsetService `will return` SUNRISE_SUNSET).fromGeographicCoordinates(any())
 
- val locationResponse : LocationResponse = get(url = "${API_LOCATION}/${GOOGLE_ADDRESS}")
+ val locationResponse : LocationResponse = get(url = "$API_LOCATION/$GOOGLE_ADDRESS")
  locationResponse.geographicCoordinates `should not be` null
 
  geoLocationService reset `mock responses`

src/test/kotlin/org/learning/by/example/reactive/kotlin/microservices/KotlinReactiveMS/routers/MainRouterTest.kt

@@ -60,7 +60,7 @@ private class MainRouterTest : BasicIntegrationTest() {
  (geoLocationService `will return` GOOGLE_LOCATION).fromAddress(any())
  (sunriseSunsetService `will return` SUNRISE_SUNSET).fromGeographicCoordinates(any())
 
- val locationResponse : LocationResponse = get(url = "${API_LOCATION}/${GOOGLE_ADDRESS}")
+ val locationResponse : LocationResponse = get(url = "$API_LOCATION/$GOOGLE_ADDRESS")
  locationResponse.geographicCoordinates `should not be` null
 
  geoLocationService reset `mock responses`

src/test/kotlin/org/learning/by/example/reactive/kotlin/microservices/KotlinReactiveMS/routers/StaticRouterTest.kt

@@ -37,7 +37,7 @@ private class StaticRouterTest : BasicIntegrationTest() {
 
  private fun verifyTitleIs(html: String, title: String) {
  val doc = Jsoup.parse(html)
- val element = doc.head().getElementsByTag(TITLE_TAG).get(0)
+ val element = doc.head().getElementsByTag(TITLE_TAG)[0]
  val text = element.text()
  text `should equal to` title
  }