use retrieve instead of exchange

Author: juan-medina

src/main/kotlin/org/learning/by/example/reactive/kotlin/microservices/KotlinReactiveMS/services/GeoLocationServiceImpl.kt

@@ -5,8 +5,11 @@ import org.learning.by.example.reactive.kotlin.microservices.KotlinReactiveMS.ex
 import org.learning.by.example.reactive.kotlin.microservices.KotlinReactiveMS.exceptions.InvalidParametersException
 import org.learning.by.example.reactive.kotlin.microservices.KotlinReactiveMS.model.GeoLocationResponse
 import org.learning.by.example.reactive.kotlin.microservices.KotlinReactiveMS.model.GeographicCoordinates
+import org.springframework.http.HttpStatus
 import org.springframework.http.MediaType
+import org.springframework.http.ResponseEntity
 import org.springframework.web.reactive.function.client.WebClient
+import org.springframework.web.reactive.function.client.toEntity
 import reactor.core.publisher.Mono
 import reactor.core.publisher.toMono
 
@@ -18,6 +21,7 @@ open internal class GeoLocationServiceImpl(val endPoint: String, var webClient:
  const val OK_STATUS = "OK"
  const val ZERO_RESULTS = "ZERO_RESULTS"
  const val ERROR_GETTING_LOCATION = "error getting location"
+ const val ERROR_NOT_200 = "response was not 200"
  const val ADDRESS_NOT_FOUND = "address not found"
  }
 
@@ -39,13 +43,15 @@ open internal class GeoLocationServiceImpl(val endPoint: String, var webClient:
  webClient.get()
  .uri(it)
  .accept(MediaType.APPLICATION_JSON)
- .exchange()
- .flatMap { it.bodyToMono(GeoLocationResponse::class.java) }
+ .retrieve()
+ .toEntity<GeoLocationResponse>()
  }
 
- open internal fun geometryLocation(geoLocationResponseMono: Mono<GeoLocationResponse>) =
- geoLocationResponseMono.flatMap {
- with(it) {
+ open internal fun geometryLocation(responseMono: Mono<ResponseEntity<GeoLocationResponse>>) =
+ responseMono.flatMap {
+ if (it.statusCode != HttpStatus.OK)
+ GetGeoLocationException(ERROR_NOT_200).toMono()
+ else with(it.body) {
  when (status) {
  OK_STATUS -> with(results[0].geometry.location) { GeographicCoordinates(lat, lng).toMono() }
  ZERO_RESULTS -> GeoLocationNotFoundException(ADDRESS_NOT_FOUND).toMono()

src/main/kotlin/org/learning/by/example/reactive/kotlin/microservices/KotlinReactiveMS/services/SunriseSunsetServiceImpl.kt

@@ -4,8 +4,11 @@ import org.learning.by.example.reactive.kotlin.microservices.KotlinReactiveMS.ex
 import org.learning.by.example.reactive.kotlin.microservices.KotlinReactiveMS.model.GeoTimesResponse
 import org.learning.by.example.reactive.kotlin.microservices.KotlinReactiveMS.model.GeographicCoordinates
 import org.learning.by.example.reactive.kotlin.microservices.KotlinReactiveMS.model.SunriseSunset
+import org.springframework.http.HttpStatus
 import org.springframework.http.MediaType
+import org.springframework.http.ResponseEntity
 import org.springframework.web.reactive.function.client.WebClient
+import org.springframework.web.reactive.function.client.toEntity
 import reactor.core.publisher.Mono
 import reactor.core.publisher.toMono
 
@@ -17,6 +20,7 @@ open internal class SunriseSunsetServiceImpl(val endPoint: String, var webClient
  const val NOT_FORMATTED = "0"
  const val ERROR_GETTING_DATA = "error getting sunrise and sunset"
  const val SUNRISE_RESULT_NOT_OK = "sunrise and sunset result was not OK"
+ const val ERROR_NOT_200 = "response was not 200"
  const val STATUS_OK = "OK"
  }
 
@@ -37,13 +41,15 @@ open internal class SunriseSunsetServiceImpl(val endPoint: String, var webClient
  webClient.get()
  .uri(it)
  .accept(MediaType.APPLICATION_JSON)
- .exchange()
- .flatMap { it.bodyToMono(GeoTimesResponse::class.java) }
- }!!
+ .retrieve()
+ .toEntity<GeoTimesResponse>()
+ }
 
- open internal fun createResult(geoTimesResponseMono: Mono<GeoTimesResponse>) =
- geoTimesResponseMono.flatMap {
- with(it){
+ open internal fun createResult(responseMono: Mono<ResponseEntity<GeoTimesResponse>>) =
+ responseMono.flatMap {
+ if (it.statusCode != HttpStatus.OK)
+ GetSunriseSunsetException(ERROR_NOT_200).toMono()
+ else with(it.body) {
  if (status == STATUS_OK) with(results) { SunriseSunset(sunrise, sunset).toMono() }
  else GetSunriseSunsetException(SUNRISE_RESULT_NOT_OK).toMono()
  }

src/test/kotlin/org/learning/by/example/reactive/kotlin/microservices/KotlinReactiveMS/services/GeoLocationServiceImplTest.kt

@@ -14,6 +14,8 @@ import org.learning.by.example.reactive.kotlin.microservices.KotlinReactiveMS.mo
 import org.learning.by.example.reactive.kotlin.microservices.KotlinReactiveMS.test.*
 import org.learning.by.example.reactive.kotlin.microservices.KotlinReactiveMS.test.tags.UnitTest
 import org.springframework.boot.test.mock.mockito.SpyBean
+import org.springframework.http.HttpStatus.INTERNAL_SERVER_ERROR
+import org.springframework.http.HttpStatus.OK
 import reactor.core.publisher.Mono
 import reactor.core.publisher.toMono
 
@@ -33,127 +35,146 @@ private class GeoLocationServiceImplTest {
  const val JSON_NOT_FOUND = "/json/GeoLocationResponse_NOT_FOUND.json"
  const val JSON_EMPTY = "/json/GeoLocationResponse_EMPTY.json"
  const val JSON_WRONG_STATUS = "/json/GeoLocationResponse_WRONG_STATUS.json"
- val LOCATION_OK = getMonoFromJsonPath(JSON_OK, GeoLocationResponse::class)
- val LOCATION_NOT_FOUND = getMonoFromJsonPath(JSON_NOT_FOUND, GeoLocationResponse::class)
- val LOCATION_EMPTY = getMonoFromJsonPath(JSON_EMPTY, GeoLocationResponse::class)
- val LOCATION_WRONG_STATUS = getMonoFromJsonPath(JSON_WRONG_STATUS, GeoLocationResponse::class)
+ val LOCATION_OK = getEntityFromJsonPath(JSON_OK, GeoLocationResponse::class)
+ val LOCATION_NOT_FOUND = getEntityFromJsonPath(JSON_NOT_FOUND, GeoLocationResponse::class)
+ val LOCATION_EMPTY = getEntityFromJsonPath(JSON_EMPTY, GeoLocationResponse::class)
+ val LOCATION_ERROR = getEntityFromJsonPath(JSON_EMPTY, GeoLocationResponse::class, INTERNAL_SERVER_ERROR)
+ val LOCATION_WRONG_STATUS = getEntityFromJsonPath(JSON_WRONG_STATUS, GeoLocationResponse::class)
  val LOCATION_EXCEPTION: Mono<GeoLocationResponse> = GetGeoLocationException(BAD_EXCEPTION).toMono()
  val BIG_EXCEPTION: Mono<GeoLocationResponse> = RuntimeException(BAD_EXCEPTION).toMono()
  }
 
  @SpyBean(GeoLocationService::class)
- lateinit var geoLocationServiceImpl: GeoLocationServiceImpl
+ lateinit var serviceImpl: GeoLocationServiceImpl
 
 
  @Test
  fun getMockingWebClientTest() {
- geoLocationServiceImpl.webClient = geoLocationServiceImpl.webClient `with mock response` LOCATION_OK
+ serviceImpl.webClient = serviceImpl.webClient mocking LOCATION_OK
 
  val geoLocationResponse = GOOGLE_ADDRESS_MONO
- .transform(geoLocationServiceImpl::buildUrl)
- .transform(geoLocationServiceImpl::get).block()
- geoLocationResponse.status `should equal` OK_STATUS
+ .transform(serviceImpl::buildUrl)
+ .transform(serviceImpl::get).block()
 
- geoLocationServiceImpl.webClient reset `mock responses`
+ geoLocationResponse.statusCode `should equal` OK
+
+ geoLocationResponse.body.status `should equal` OK_STATUS
+
+ serviceImpl.webClient reset `mock responses`
+ }
+
+ @Test
+ fun getMockingWebClientErrorTest() {
+ serviceImpl.webClient = serviceImpl.webClient mocking LOCATION_ERROR
+
+ val geoLocationResponse = GOOGLE_ADDRESS_MONO
+ .transform(serviceImpl::buildUrl)
+ .transform(serviceImpl::get)
+ .block()
+
+ geoLocationResponse.statusCode `should be` INTERNAL_SERVER_ERROR
+
+ serviceImpl.webClient reset `mock responses`
  }
 
  @Test
  fun fromAddressTest() {
- (geoLocationServiceImpl `will return` LOCATION_OK).get(any())
 
- val geographicCoordinates = geoLocationServiceImpl.fromAddress(GOOGLE_ADDRESS_MONO).block()
+ (serviceImpl `will return` LOCATION_OK).get(any())
+
+ val geographicCoordinates = serviceImpl.fromAddress(GOOGLE_ADDRESS_MONO).block()
  geographicCoordinates `should equal` GeographicCoordinates(GOOGLE_LAT, GOOGLE_LNG)
 
- geoLocationServiceImpl reset `mock responses`
+ serviceImpl reset `mock responses`
  }
 
  @Test
  fun fromAddressNotFoundTest() {
 
- (geoLocationServiceImpl `will return` LOCATION_NOT_FOUND).get(any())
+ (serviceImpl `will return` LOCATION_NOT_FOUND).get(any())
 
- val geographicCoordinates: GeographicCoordinates? = geoLocationServiceImpl.fromAddress(GOOGLE_ADDRESS_MONO)
+ val geographicCoordinates: GeographicCoordinates? = serviceImpl.fromAddress(GOOGLE_ADDRESS_MONO)
  .onErrorResume {
  it `should be instance of` GeoLocationNotFoundException::class
  Mono.empty()
  }
  .block()
  geographicCoordinates `should be` null
 
- geoLocationServiceImpl reset `mock responses`
+ serviceImpl reset `mock responses`
  }
 
  @Test
  fun fromAddressEmptyTest() {
- (geoLocationServiceImpl `will return` LOCATION_EMPTY).get(any())
+ (serviceImpl `will return` LOCATION_EMPTY).get(any())
 
- val geographicCoordinates: GeographicCoordinates? = geoLocationServiceImpl.fromAddress(GOOGLE_ADDRESS_MONO)
+ val geographicCoordinates: GeographicCoordinates? = serviceImpl.fromAddress(GOOGLE_ADDRESS_MONO)
  .onErrorResume {
  it `should be instance of` GetGeoLocationException::class
  Mono.empty()
  }
  .block()
  geographicCoordinates `should be` null
 
- geoLocationServiceImpl reset `mock responses`
+ serviceImpl reset `mock responses`
  }
 
 
  @Test
  fun fromAddressWrongStatusTest() {
- (geoLocationServiceImpl `will return` LOCATION_WRONG_STATUS).get(any())
+ (serviceImpl `will return` LOCATION_WRONG_STATUS).get(any())
 
- val geographicCoordinates: GeographicCoordinates? = geoLocationServiceImpl.fromAddress(GOOGLE_ADDRESS_MONO)
+ val geographicCoordinates: GeographicCoordinates? = serviceImpl.fromAddress(GOOGLE_ADDRESS_MONO)
  .onErrorResume {
  it `should be instance of` GetGeoLocationException::class
  Mono.empty()
  }
  .block()
  geographicCoordinates `should be` null
 
- geoLocationServiceImpl reset `mock responses`
+ serviceImpl reset `mock responses`
  }
 
  @Test
  fun fromAddressExceptionTest() {
- (geoLocationServiceImpl `will return` LOCATION_EXCEPTION).get(any())
+ (serviceImpl `will return` LOCATION_EXCEPTION).get(any())
 
- val geographicCoordinates: GeographicCoordinates? = geoLocationServiceImpl.fromAddress(GOOGLE_ADDRESS_MONO)
+ val geographicCoordinates: GeographicCoordinates? = serviceImpl.fromAddress(GOOGLE_ADDRESS_MONO)
  .onErrorResume {
  it `should be instance of` GetGeoLocationException::class
  Mono.empty()
  }
  .block()
  geographicCoordinates `should be` null
 
- geoLocationServiceImpl reset `mock responses`
+ serviceImpl reset `mock responses`
  }
 
  @Test
  fun fromAddressBigExceptionTest() {
- (geoLocationServiceImpl `will return` BIG_EXCEPTION).get(any())
+ (serviceImpl `will return` BIG_EXCEPTION).get(any())
 
- val geographicCoordinates: GeographicCoordinates? = geoLocationServiceImpl.fromAddress(GOOGLE_ADDRESS_MONO)
+ val geographicCoordinates: GeographicCoordinates? = serviceImpl.fromAddress(GOOGLE_ADDRESS_MONO)
  .onErrorResume {
  it `should be instance of` GetGeoLocationException::class
  Mono.empty()
  }
  .block()
  geographicCoordinates `should be` null
 
- geoLocationServiceImpl reset `mock responses`
+ serviceImpl reset `mock responses`
  }
 
 
  @Test
  fun buildUrlTest() {
- val url = GOOGLE_ADDRESS_MONO.transform(geoLocationServiceImpl::buildUrl).block()
- url `should equal` geoLocationServiceImpl.endPoint + GOOGLE_ADDRESS_IN_PARAMS
+ val url = GOOGLE_ADDRESS_MONO.transform(serviceImpl::buildUrl).block()
+ url `should equal` serviceImpl.endPoint + GOOGLE_ADDRESS_IN_PARAMS
  }
 
  @Test
  fun buildUrlEmptyAddressTest() {
- val url = "".toMono().transform(geoLocationServiceImpl::buildUrl).onErrorResume {
+ val url = "".toMono().transform(serviceImpl::buildUrl).onErrorResume {
  it `should be instance of` InvalidParametersException::class
  Mono.empty()
  }.block()