Skip to content

Show error message on failure #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Show error message on failure #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/sdk-utils/src/lib/httpClient.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ module.exports = new class httpClient {
})
.catch(error => {
if (error.response) {
throw new Error(JSON.stringify(error.response.data));
throw new Error(error.response.data.error.message);
}
if (error.request) {
throw new Error(error.toJSON().message);
Expand Down
4 changes: 2 additions & 2 deletions packages/sdk-utils/src/smartui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ async function fetchDOMSerializer() {
return await client.fetchDOMSerializer();
} catch (error) {
log.debug(error);
throw new Error(`fetch DOMSerializer failed`);
throw new Error(`fetch DOMSerializer failed; ${error.message}`);
}
}

Expand All @@ -32,7 +32,7 @@ async function postSnapshot(snapshot, testType) {
return await client.postSnapshot(data);
} catch (error) {
log.debug(error);
throw new Error(`post snapshot failed`);
throw new Error(`post snapshot failed; ${error.message}`);
}
}

Expand Down