Skip to content

Commit 107f9d1

Browse files
committed
Minor fixes plus typos.
1 parent 53f412b commit 107f9d1

File tree

5 files changed

+5
-22
lines changed

5 files changed

+5
-22
lines changed

app/src/main/kotlin/com/fernandocejas/sample/core/interactor/UseCase.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import kotlinx.coroutines.launch
2424

2525
/**
2626
* Abstract class for a Use Case (Interactor in terms of Clean Architecture).
27-
* This abstraction represents an execution unit for different use cases (this means than any use
27+
* This abstraction represents an execution unit for different use cases (this means that any use
2828
* case in the application should implement this contract).
2929
*
3030
* By convention each [UseCase] implementation will execute its job in a background thread

app/src/main/kotlin/com/fernandocejas/sample/features/movies/Movie.kt

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,4 @@
1515
*/
1616
package com.fernandocejas.sample.features.movies
1717

18-
import com.fernandocejas.sample.core.extension.empty
19-
20-
data class Movie(val id: Int, val poster: String) {
21-
22-
companion object {
23-
fun empty() = Movie(0, String.empty())
24-
}
25-
}
18+
data class Movie(val id: Int, val poster: String)

app/src/main/kotlin/com/fernandocejas/sample/features/movies/MovieDetails.kt

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -15,21 +15,11 @@
1515
*/
1616
package com.fernandocejas.sample.features.movies
1717

18-
import com.fernandocejas.sample.core.extension.empty
19-
2018
data class MovieDetails(val id: Int,
2119
val title: String,
2220
val poster: String,
2321
val summary: String,
2422
val cast: String,
2523
val director: String,
2624
val year: Int,
27-
val trailer: String) {
28-
29-
companion object {
30-
fun empty() = MovieDetails(0, String.empty(), String.empty(), String.empty(),
31-
String.empty(), String.empty(), 0, String.empty())
32-
}
33-
}
34-
35-
25+
val trailer: String)

app/src/main/kotlin/com/fernandocejas/sample/features/movies/MovieDetailsEntity.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ data class MovieDetailsEntity(private val id: Int,
2727
private val trailer: String) {
2828

2929
companion object {
30-
fun empty() = MovieDetailsEntity(0, String.empty(), String.empty(), String.empty(),
30+
val empty = MovieDetailsEntity(0, String.empty(), String.empty(), String.empty(),
3131
String.empty(), String.empty(), 0, String.empty())
3232
}
3333

app/src/main/kotlin/com/fernandocejas/sample/features/movies/MoviesRepository.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ interface MoviesRepository {
4242

4343
override fun movieDetails(movieId: Int): Either<Failure, MovieDetails> {
4444
return when (networkHandler.isNetworkAvailable()) {
45-
true -> request(service.movieDetails(movieId), { it.toMovieDetails() }, MovieDetailsEntity.empty())
45+
true -> request(service.movieDetails(movieId), { it.toMovieDetails() }, MovieDetailsEntity.empty)
4646
false -> Left(NetworkConnection)
4747
}
4848
}

0 commit comments

Comments
 (0)