Fix linter support for trailing comma in function's args list, fixes Scony#206

Author: Scony

CHANGELOG.md

@@ -11,6 +11,7 @@
  - Default regex for names of constants now allows underscore as a prefix to denote private contants (#223)
  - Fixed parsing of files without newline at the end of file ending with comment (#237)
  - Fixed linter support for docstrings (#233)
+ - Fixed linter support for trailing comma in function's args list (#206)
 
 ## [4.1.0] 2023-07-06
 

gdtoolkit/linter/basic_checks.py

@@ -4,7 +4,7 @@
 from lark import Tree, Token
 
 from ..common.utils import find_name_token_among_children, get_line, get_column
-from ..formatter.expression_utils import remove_outer_parentheses
+from ..formatter.expression_utils import remove_outer_parentheses, is_trailing_comma
 
 from .problem import Problem
 
@@ -127,7 +127,7 @@ def _unused_argument_check(parse_tree: Tree) -> List[Problem]:
  argument_definitions = {} # type: Dict[str, int]
  argument_tokens = {}
  func_args = func_header.children[1]
- for func_arg in func_args.children:
+ for func_arg in [r for r in func_args.children if not is_trailing_comma(r)]:
  arg_name_token = find_name_token_among_children(func_arg)
  arg_name = arg_name_token.value # type: ignore
  argument_definitions[arg_name] = (

tests/linter/test_basic_corner_cases.py

@@ -14,3 +14,12 @@ def test_newlineless_code():
 def test_docstring():
  code = '"""\nhello world!\n"""'
  lint_code(code)
+
+
+def test_trailing_comma_in_params_list():
+ code = """static func _is_agent_placement_position_valid(
+ position,
+ radius,
+ existing_units,
+ navigation_map_rid,):pass"""
+ lint_code(code)