feat: Add secondary_boot_disks to node_pool configuration. (terraform-google-modules#1946)

Author: yorik

README.md

@@ -325,6 +325,7 @@ The node_pools variable takes the following parameters:
 | value | The value for the taint | | Required |
 | version | The Kubernetes version for the nodes in this pool. Should only be set if auto_upgrade is false | " " | Optional |
 | location_policy | [Location policy](https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_node_pool#location_policy) specifies the algorithm used when scaling-up the node pool. Location policy is supported only in 1.24.1+ clusters. | " " | Optional |
+| secondary_boot_disk | Image of a secondary boot disk to preload container images and data on new nodes. For detail see [documentation](https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_cluster#nested_secondary_boot_disks). `gcfs_config` must be `enabled=true` for this feature to work. | | Optional |
 
 ## windows_node_pools variable
 The windows_node_pools variable takes the same parameters as [node_pools](#node\_pools-variable) but is reserved for provisioning Windows based node pools only. This variable is introduced to satisfy a [specific requirement](https://cloud.google.com/kubernetes-engine/docs/how-to/creating-a-cluster-windows#create_a_cluster_and_node_pools) for the presence of at least one linux based node pool in the cluster before a windows based node pool can be created.

autogen/main/README.md

@@ -250,6 +250,7 @@ The node_pools variable takes the following parameters:
 | value | The value for the taint | | Required |
 | version | The Kubernetes version for the nodes in this pool. Should only be set if auto_upgrade is false | " " | Optional |
 | location_policy | [Location policy](https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_node_pool#location_policy) specifies the algorithm used when scaling-up the node pool. Location policy is supported only in 1.24.1+ clusters. | " " | Optional |
+| secondary_boot_disk | Image of a secondary boot disk to preload container images and data on new nodes. For detail see [documentation](https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_cluster#nested_secondary_boot_disks). `gcfs_config` must be `enabled=true` for this feature to work. | | Optional |
 
 ## windows_node_pools variable
 The windows_node_pools variable takes the same parameters as [node_pools](#node\_pools-variable) but is reserved for provisioning Windows based node pools only. This variable is introduced to satisfy a [specific requirement](https://cloud.google.com/kubernetes-engine/docs/how-to/creating-a-cluster-windows#create_a_cluster_and_node_pools) for the presence of at least one linux based node pool in the cluster before a windows based node pool can be created.

autogen/main/cluster.tf.tmpl

@@ -864,6 +864,15 @@ resource "google_container_node_pool" "windows_pools" {
  }
  }
 
+ # Supports a single secondary boot disk because `map(any)` must have the same values type.
+ dynamic "secondary_boot_disks" {
+ for_each = lookup(each.value, "secondary_boot_disk", "") != "" ? [each.value.secondary_boot_disk] : []
+ content {
+ disk_image = secondary_boot_disks.value
+ mode = "CONTAINER_IMAGE_CACHE"
+ }
+ }
+
  service_account = lookup(
  each.value,
  "service_account",

cluster.tf

@@ -582,6 +582,15 @@ resource "google_container_node_pool" "pools" {
  }
  }
 
+ # Supports a single secondary boot disk because `map(any)` must have the same values type.
+ dynamic "secondary_boot_disks" {
+ for_each = lookup(each.value, "secondary_boot_disk", "") != "" ? [each.value.secondary_boot_disk] : []
+ content {
+ disk_image = secondary_boot_disks.value
+ mode = "CONTAINER_IMAGE_CACHE"
+ }
+ }
+
  service_account = lookup(
  each.value,
  "service_account",
@@ -798,6 +807,15 @@ resource "google_container_node_pool" "windows_pools" {
  }
  }
 
+ # Supports a single secondary boot disk because `map(any)` must have the same values type.
+ dynamic "secondary_boot_disks" {
+ for_each = lookup(each.value, "secondary_boot_disk", "") != "" ? [each.value.secondary_boot_disk] : []
+ content {
+ disk_image = secondary_boot_disks.value
+ mode = "CONTAINER_IMAGE_CACHE"
+ }
+ }
+
  service_account = lookup(
  each.value,
  "service_account",

modules/beta-private-cluster-update-variant/README.md

@@ -391,6 +391,7 @@ The node_pools variable takes the following parameters:
 | value | The value for the taint | | Required |
 | version | The Kubernetes version for the nodes in this pool. Should only be set if auto_upgrade is false | " " | Optional |
 | location_policy | [Location policy](https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_node_pool#location_policy) specifies the algorithm used when scaling-up the node pool. Location policy is supported only in 1.24.1+ clusters. | " " | Optional |
+| secondary_boot_disk | Image of a secondary boot disk to preload container images and data on new nodes. For detail see [documentation](https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_cluster#nested_secondary_boot_disks). `gcfs_config` must be `enabled=true` for this feature to work. | | Optional |
 
 ## windows_node_pools variable
 The windows_node_pools variable takes the same parameters as [node_pools](#node\_pools-variable) but is reserved for provisioning Windows based node pools only. This variable is introduced to satisfy a [specific requirement](https://cloud.google.com/kubernetes-engine/docs/how-to/creating-a-cluster-windows#create_a_cluster_and_node_pools) for the presence of at least one linux based node pool in the cluster before a windows based node pool can be created.

modules/beta-private-cluster-update-variant/cluster.tf

@@ -748,6 +748,15 @@ resource "google_container_node_pool" "pools" {
  }
  }
 
+ # Supports a single secondary boot disk because `map(any)` must have the same values type.
+ dynamic "secondary_boot_disks" {
+ for_each = lookup(each.value, "secondary_boot_disk", "") != "" ? [each.value.secondary_boot_disk] : []
+ content {
+ disk_image = secondary_boot_disks.value
+ mode = "CONTAINER_IMAGE_CACHE"
+ }
+ }
+
  service_account = lookup(
  each.value,
  "service_account",
@@ -990,6 +999,15 @@ resource "google_container_node_pool" "windows_pools" {
  }
  }
 
+ # Supports a single secondary boot disk because `map(any)` must have the same values type.
+ dynamic "secondary_boot_disks" {
+ for_each = lookup(each.value, "secondary_boot_disk", "") != "" ? [each.value.secondary_boot_disk] : []
+ content {
+ disk_image = secondary_boot_disks.value
+ mode = "CONTAINER_IMAGE_CACHE"
+ }
+ }
+
  service_account = lookup(
  each.value,
  "service_account",

modules/beta-private-cluster/README.md

@@ -369,6 +369,7 @@ The node_pools variable takes the following parameters:
 | value | The value for the taint | | Required |
 | version | The Kubernetes version for the nodes in this pool. Should only be set if auto_upgrade is false | " " | Optional |
 | location_policy | [Location policy](https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_node_pool#location_policy) specifies the algorithm used when scaling-up the node pool. Location policy is supported only in 1.24.1+ clusters. | " " | Optional |
+| secondary_boot_disk | Image of a secondary boot disk to preload container images and data on new nodes. For detail see [documentation](https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_cluster#nested_secondary_boot_disks). `gcfs_config` must be `enabled=true` for this feature to work. | | Optional |
 
 ## windows_node_pools variable
 The windows_node_pools variable takes the same parameters as [node_pools](#node\_pools-variable) but is reserved for provisioning Windows based node pools only. This variable is introduced to satisfy a [specific requirement](https://cloud.google.com/kubernetes-engine/docs/how-to/creating-a-cluster-windows#create_a_cluster_and_node_pools) for the presence of at least one linux based node pool in the cluster before a windows based node pool can be created.

modules/beta-private-cluster/cluster.tf

@@ -673,6 +673,15 @@ resource "google_container_node_pool" "pools" {
  }
  }
 
+ # Supports a single secondary boot disk because `map(any)` must have the same values type.
+ dynamic "secondary_boot_disks" {
+ for_each = lookup(each.value, "secondary_boot_disk", "") != "" ? [each.value.secondary_boot_disk] : []
+ content {
+ disk_image = secondary_boot_disks.value
+ mode = "CONTAINER_IMAGE_CACHE"
+ }
+ }
+
  service_account = lookup(
  each.value,
  "service_account",
@@ -914,6 +923,15 @@ resource "google_container_node_pool" "windows_pools" {
  }
  }
 
+ # Supports a single secondary boot disk because `map(any)` must have the same values type.
+ dynamic "secondary_boot_disks" {
+ for_each = lookup(each.value, "secondary_boot_disk", "") != "" ? [each.value.secondary_boot_disk] : []
+ content {
+ disk_image = secondary_boot_disks.value
+ mode = "CONTAINER_IMAGE_CACHE"
+ }
+ }
+
  service_account = lookup(
  each.value,
  "service_account",

modules/beta-public-cluster-update-variant/README.md

@@ -379,6 +379,7 @@ The node_pools variable takes the following parameters:
 | value | The value for the taint | | Required |
 | version | The Kubernetes version for the nodes in this pool. Should only be set if auto_upgrade is false | " " | Optional |
 | location_policy | [Location policy](https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_node_pool#location_policy) specifies the algorithm used when scaling-up the node pool. Location policy is supported only in 1.24.1+ clusters. | " " | Optional |
+| secondary_boot_disk | Image of a secondary boot disk to preload container images and data on new nodes. For detail see [documentation](https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_cluster#nested_secondary_boot_disks). `gcfs_config` must be `enabled=true` for this feature to work. | | Optional |
 
 ## windows_node_pools variable
 The windows_node_pools variable takes the same parameters as [node_pools](#node\_pools-variable) but is reserved for provisioning Windows based node pools only. This variable is introduced to satisfy a [specific requirement](https://cloud.google.com/kubernetes-engine/docs/how-to/creating-a-cluster-windows#create_a_cluster_and_node_pools) for the presence of at least one linux based node pool in the cluster before a windows based node pool can be created.

modules/beta-public-cluster-update-variant/cluster.tf

@@ -729,6 +729,15 @@ resource "google_container_node_pool" "pools" {
  }
  }
 
+ # Supports a single secondary boot disk because `map(any)` must have the same values type.
+ dynamic "secondary_boot_disks" {
+ for_each = lookup(each.value, "secondary_boot_disk", "") != "" ? [each.value.secondary_boot_disk] : []
+ content {
+ disk_image = secondary_boot_disks.value
+ mode = "CONTAINER_IMAGE_CACHE"
+ }
+ }
+
  service_account = lookup(
  each.value,
  "service_account",
@@ -971,6 +980,15 @@ resource "google_container_node_pool" "windows_pools" {
  }
  }
 
+ # Supports a single secondary boot disk because `map(any)` must have the same values type.
+ dynamic "secondary_boot_disks" {
+ for_each = lookup(each.value, "secondary_boot_disk", "") != "" ? [each.value.secondary_boot_disk] : []
+ content {
+ disk_image = secondary_boot_disks.value
+ mode = "CONTAINER_IMAGE_CACHE"
+ }
+ }
+
  service_account = lookup(
  each.value,
  "service_account",