Fix timezone issue #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ence in timezone. This version will create a new ISO date string that considers the user's timezone, and forwards this new ISO time string to Notion, resulting in the correct time being presented to the user. This method uses the timezone that the machine is operating on. *So if the user provides a timezone different from the one they are in*, for some reason, the time that will go into Notion will be in accordance with the timezone their machine is currently in (i.e. using JavaScript's Date functionality).
JamesNZL requested changes Aug 29, 2022
…ded timezone, then calculates the correct date string to give to Notion. Default timezone is 'Pacific/Auckland'.
JamesNZL requested changes Aug 29, 2022
…ne to guess the user's timezone based on their location if they did not provide a timezone.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Reformatted date strings received from Canvas to account for a difference in timezone. This version will create a new ISO date string that considers the user's timezone, and forwards this new ISO time string to Notion, resulting in the correct time being presented to the user. This method uses the timezone that the machine is operating on. So if the user provides a timezone different from the one they are in, for some reason, the time that will go into Notion will be in accordance with the timezone their machine is currently in (i.e. using JavaScript's Date functionality), not the timezone they have manually entered.