TASK: fixed npmScopeArg rewriting, exclude all special characters. Only dash-cased name allowed

Author: Roman Heckendorf

packages/create-react-microservice/src/commands/default.js

@@ -99,14 +99,9 @@ class CreateReactMicroService extends Command {
  .findNodeModules({cwd: __dirname})
  .map(modulesPath => path.join(__dirname, modulesPath))
  .find(modulesPath =>
- file.existsSync(
- path.join(modulesPath, scaffoldPackageName)
- )
+ file.existsSync(path.join(modulesPath, scaffoldPackageName))
  );
- const scaffoldPackagePath = path.join(
- modulesPath,
- scaffoldPackageName
- );
+ const scaffoldPackagePath = path.join(modulesPath, scaffoldPackageName);
  const scaffoldPackageJson = file.require(
  path.join(scaffoldPackageName, 'package.json')
  );
@@ -203,7 +198,7 @@ class CreateReactMicroService extends Command {
  const namespace = str
  .replace(/\s/g, '-')
  .replace(/[0-9]/g, '')
- .replace(/[^a-zA-Z]g/g, '')
+ .replace(/[^a-zA-Z-]/g, '')
  .toLowerCase();
 
  return `@${namespace}/`;
@@ -271,7 +266,7 @@ class CreateReactMicroService extends Command {
  const srcGitIgnore = path.join(cwd, '.git-ignore');
 
  if (file.existsSync(srcGitIgnore)) {
- file.renameSync(srcGitIgnore, path.join(cwd, '.gitignore'))
+ file.renameSync(srcGitIgnore, path.join(cwd, '.gitignore'));
  }
 
  await Command.exec('git', ['init'], opts);

packages/create-react-microservice/src/commands/default.spec.js

@@ -462,6 +462,47 @@ describe('new Command().safelyCreateNpmScopeArg()', () => {
  '@foo-bar-baz/'
  );
  });
+ it('should remove all special characters', async () => {
+ const specialChars = [
+ '~',
+ '!',
+ '@',
+ '#',
+ '$',
+ '%',
+ '^',
+ '&',
+ '*',
+ '(',
+ ')',
+ '_',
+ '|',
+ '+',
+ '=',
+ '?',
+ ';',
+ ':',
+ ',',
+ '.',
+ '<',
+ '>',
+ '{',
+ '}',
+ '[',
+ ']',
+ '\\',
+ '/',
+ "'",
+ '"',
+ '`',
+ '´'
+ ];
+ specialChars.forEach(character => {
+ expect(instance.safelyCreateNpmScopeArg(`${character}foo-bar`)).toBe(
+ '@foo-bar/'
+ );
+ });
+ });
 });
 
 describe('new Command().printStartInstructions()', () => {