feat(functions/helloPubSub): use new FF testing layer #2645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added the samples 
ace-n approved these changes May 11, 2022
Contributor
ace-n left a comment
ace-n left a comment There was a problem hiding this comment.
LGTM once lint errors and comments addressed.
RE testing - I wonder if the FF is running a server under the hood? Trying to run two servers on the same port might cause failures.
(We can chat more about this later this afternoon, too.)
| }, | ||
| "scripts": { | ||
| "test": "mocha test/index.test.js" | ||
| "test": "mocha tests/*-tests.js --timeout=60000" |
Contributor
There was a problem hiding this comment.
Nit: I believe this repo's convention is to use a test directory (no s)
ace-n changed the title 
averikitsch reviewed May 12, 2022
averikitsch approved these changes May 12, 2022
product-auto-label bot added the api: cloudfunctions 
Co-authored-by: Averi Kitsch <akitsch@google.com>
ace-n changed the title 
sofisl approved these changes May 18, 2022
averikitsch added the kokoro:force-run 
kokoro-team removed the kokoro:force-run Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In this PR:
❓ I noticed that I can run
mocha tests/integration-tests.jsormocha tests/unit-tests.jssuccessfully individually. But if I try to follow the style in other samples by runningnpm run testwhere test ismocha tests/*-tests.js --timeout=60000, the second test that's run will fail.