Skip to content

Commit e8d83aa

Browse files
sterenfhinkel
authored andcommitted
Simplify sample, fix unit test (#746)
1 parent b81ec57 commit e8d83aa

File tree

1 file changed

+16
-19
lines changed
  • appengine/headless-chrome

1 file changed

+16
-19
lines changed

appengine/headless-chrome/app.js

Lines changed: 16 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -22,39 +22,36 @@ const app = express();
2222

2323
let browser;
2424

25-
async function init () {
26-
// [START browser]
27-
browser = await puppeteer.launch({
28-
args: ['--no-sandbox']
29-
});
30-
// [END browser]
31-
32-
const server = app.listen(process.env.PORT || 8080, async err => {
33-
if (err) {
34-
await browser.close();
35-
return console.error(err);
36-
}
37-
const port = server.address().port;
38-
console.info(`App listening on port ${port}`);
39-
});
40-
}
41-
42-
init();
43-
4425
app.use(async (req, res) => {
4526
const url = req.query.url;
4627

4728
if (!url) {
4829
return res.send('Please provide URL as GET parameter, for example: <a href="/?url=https://example.com">?url=https://example.com</a>');
4930
}
5031

32+
if (!browser) {
33+
// [START browser]
34+
browser = await puppeteer.launch({
35+
args: ['--no-sandbox']
36+
});
37+
// [END browser]
38+
}
39+
5140
let page = await browser.newPage();
5241
await page.goto(url);
5342
const imageBuffer = await page.screenshot();
5443

5544
res.set('Content-Type', 'image/png');
5645
res.send(imageBuffer);
5746
});
47+
48+
const server = app.listen(process.env.PORT || 8080, err => {
49+
if (err) {
50+
return console.error(err);
51+
}
52+
const port = server.address().port;
53+
console.info(`App listening on port ${port}`);
54+
});
5855
// [END full_sample]
5956

6057
module.exports = app;

0 commit comments

Comments
 (0)