Skip to content

Conversation

@caesarxuchao
Copy link
Contributor

related: #6584

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.
@nikhiljindal
Copy link
Contributor

LGTM, thanks!

@nikhiljindal nikhiljindal added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2015
nikhiljindal added a commit that referenced this pull request Apr 24, 2015
update examples/cassandra to api v1beta3
@nikhiljindal nikhiljindal merged commit 4120b71 into kubernetes:master Apr 24, 2015
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is buggy. I ran across it looking at something else. You can't just change the API version and not the calling code. Look 7 lines down - it is trying to decode this object into a v1beta1 structure.

Please audit this and other v1beta3 conversions for this same problem.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caesarxuchao Did you run the example to ensure that it worked?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only other URL I found was in rethinkdb, which hasn't been converted yet.

Good catch, thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran through the tutorial, but I didn't check if Cassandra worked properly. I submitted a PR for rethinkdb before I left today. I will ask @nikhiljindal to hold that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm "Looks good to me", indicates that a PR is ready to be merged.

5 participants