fix: set Thread Context ClassLoader correctly when invoking handler constructor #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| It be good if we had a test that can guard against regressing to the old behavior. Not sure how complex testing this would be though. WDYT? |
garethgeorge force-pushed the garethgeorge/issue/110 branch 2 times, most recently from 5beb0de to 645bde2 Compare 
garethgeorge force-pushed the garethgeorge/issue/110 branch from 645bde2 to 8def677 Compare 
| Good point, done. Added test coverage. |
janell-chen approved these changes Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Adds the same logic that is used to set the Thread Context ClassLoader when handling a request to also apply that same class loader when constructing the handler.
Addresses issue #110