Merge pull request #527 from FriendsOfSymfony/cleanup-bc

Cleanup bc

Author: dbu

CHANGELOG.md

@@ -3,12 +3,26 @@ Changelog
 
 See also the [GitHub releases page](https://github.com/FriendsOfSymfony/FOSHttpCache/releases).
 
+unreleased
+----------
+
+### Symfony Compatibility
+
+* Removed the internal BaseEvent class and extend our events from the Symfony contracts class directly.
+
 2.13.0
 ------
 
 * Allow installation with Symfony 6 components
 * Drop support for Symfony 3, minimal version is now 4.3
 
+2.12.1
+------
+
+### Symfony Compatibility
+
+* Do not extend the wrong Event class when installed with legacy Symfony but the Symfony contracts happen to be installed
+
 2.12.0
 ------
 

src/BaseEvent.php

@@ -11,6 +11,8 @@
 
 namespace FOS\HttpCache;
 
+use Symfony\Contracts\EventDispatcher\Event as BaseEvent;
+
 class Event extends BaseEvent
 {
  private $exception;

src/Event.php

@@ -11,7 +11,7 @@
 
 namespace FOS\HttpCache\SymfonyCache;
 
-use FOS\HttpCache\BaseEvent;
+use Symfony\Contracts\EventDispatcher\Event as BaseEvent;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpKernel\HttpKernelInterface;