- Notifications
You must be signed in to change notification settings - Fork 8
docs: add note on marker label's className property limitations #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds a Javadoc note to MarkerLabel.className explaining current styling limitations when using imported stylesheets in the component’s shadow root and links to a GitHub discussion. No code or API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews: pre_merge_checks: custom_checks: - name: "Undocumented Breaking Changes" mode: "warning" instructions: | Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/main/java/com/flowingcode/vaadin/addons/googlemaps/MarkerLabel.java (1)
72-77: Minor wording tweak for precision and longevity.
Rephrase to clarify that styles don’t take effect when CSS is imported into the component’s shadow root, rather than “apply the className”. No behavior change; purely editorial.- * <p> - * <strong>Note:</strong> At the moment, there is no direct way to apply the className by - * importing a stylesheet into the component's shadow root. For alternative workarounds, see - * <a href="https://github.com/FlowingCode/GoogleMapsAddon/issues/159#issuecomment-3325302923"> - * this comment on GitHub</a>. + * <p> + * <strong>Note:</strong> Styles referenced by <code>className</code> are not applied when the + * stylesheet is imported into this component's shadow root. For workarounds and discussion, see + * <a href="https://github.com/FlowingCode/GoogleMapsAddon/issues/159#issuecomment-3325302923"> + * the corresponding GitHub comment</a>.Please confirm whether this limitation is version‑specific (e.g., certain Vaadin platform versions or addon versions). If so, consider adding that scope to the note to reduce ambiguity for users.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main/java/com/flowingcode/vaadin/addons/googlemaps/MarkerLabel.java(1 hunks)
🔇 Additional comments (1)
src/main/java/com/flowingcode/vaadin/addons/googlemaps/MarkerLabel.java (1)
72-77: Helpful clarification; thanks for documenting the limitation.
The added note is valuable and scoped to the right property.



See #159 (comment)
Summary by CodeRabbit