Skip to content

Commit 3bebf3c

Browse files
paodbjavier-godoy
authored andcommitted
fix: update markers on removal
Update web-component dependency to 3.6.1 Close #109
1 parent 236832a commit 3bebf3c

File tree

4 files changed

+6
-4
lines changed

4 files changed

+6
-4
lines changed

src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMap.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
@SuppressWarnings("serial")
4545
@Tag("google-map")
4646
@JsModule("@flowingcode/google-map/google-map.js")
47-
@NpmPackage(value = "@flowingcode/google-map", version = "3.6.0")
47+
@NpmPackage(value = "@flowingcode/google-map", version = "3.6.1")
4848
@NpmPackage(value = "@googlemaps/markerclusterer", version = "2.0.8")
4949
@JsModule("./googlemaps/geolocation.js")
5050
public class GoogleMap extends Component implements HasSize {
@@ -176,6 +176,8 @@ public void addMarker(GoogleMapMarker marker) {
176176
@SuppressWarnings("squid:S3242")
177177
public void removeMarker(GoogleMapMarker marker) {
178178
this.getElement().removeChild(marker.getElement());
179+
// markers need to be updated on removal
180+
this.getElement().executeJs("this._updateMarkers()");
179181
}
180182

181183
/**

src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapMarker.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
@SuppressWarnings("serial")
4040
@Tag("google-map-marker")
4141
@JsModule("@flowingcode/google-map/google-map-marker.js")
42-
@NpmPackage(value = "@flowingcode/google-map", version = "3.6.0")
42+
@NpmPackage(value = "@flowingcode/google-map", version = "3.6.1")
4343
@NpmPackage(value = "@googlemaps/markerclusterer", version = "2.0.8")
4444
public class GoogleMapMarker extends Component {
4545

src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapPoint.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
@SuppressWarnings("serial")
2929
@Tag("google-map-point")
3030
@JsModule("@flowingcode/google-map/google-map-point.js")
31-
@NpmPackage(value = "@flowingcode/google-map", version = "3.6.0")
31+
@NpmPackage(value = "@flowingcode/google-map", version = "3.6.1")
3232
@NpmPackage(value = "@googlemaps/markerclusterer", version = "2.0.8")
3333
public class GoogleMapPoint extends Component {
3434

src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapPolygon.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
@Tag("google-map-poly")
4141
@JsModule("@flowingcode/google-map/google-map-poly.js")
4242
@JsModule("@flowingcode/google-map/google-map-point.js")
43-
@NpmPackage(value = "@flowingcode/google-map", version = "3.6.0")
43+
@NpmPackage(value = "@flowingcode/google-map", version = "3.6.1")
4444
@NpmPackage(value = "@googlemaps/markerclusterer", version = "2.0.8")
4545
public class GoogleMapPolygon extends Component {
4646

0 commit comments

Comments
 (0)