Merge pull request #82 from Lightning-Flow-Scanner/update

Update

Author: RubenHalman

README.md

@@ -80,18 +80,18 @@ sfdx flow:scan --config path/to/.flow-scanner.json
 ```
 
 ## Rule overview
-
 | Rule | Description |
 |--------------|:-----------|
 | **Outdated API Version** | Introducing newer API components may lead to unexpected issues with older versions of Flows, as they might not align with the underlying mechanics. Starting from API version 50.0, the 'Api Version' attribute has been readily available on the Flow Object. To ensure smooth operation and reduce discrepancies between API versions, it is strongly advised to regularly update and maintain them. |
 | **Copy API Name** | Maintaining multiple elements with a similar name, like 'Copy_X_Of_Element,' can diminish the overall readability of your Flow. When copying and pasting these elements, it's crucial to remember to update the API name of the newly created copy. |
-| **DML Statement In A Loop** | To prevent exceeding Apex governor limits, it is advisable to consolidate all your record-related operations, including creation, updates, or deletions, at the conclusion of the flow. |
+| **DML Statement In A Loop** | To prevent exceeding Apex governor limits, it is advisable to consolidate all your database operations, including record creation, updates, or deletions, at the conclusion of the flow. |
 | **Duplicate DML Operation** | When the flow executes database changes or actions between two screens, it's important to prevent users from navigating back between screens. Failure to do so may result in duplicate database operations being performed within the flow. |
 | **Hardcoded Id** | Avoid hard-coding IDs as they are org-specific. Instead, pass them into variables at the start of the flow. You can achieve this by utilizing merge fields in URL parameters or employing a Get Records element. |
 | **Flow Naming Convention** | The readability of a flow is of utmost importance. Establishing a naming convention for the Flow Name significantly enhances findability, searchability, and maintains overall consistency. It is advisable to include at least a domain and a brief description of the actions carried out in the flow, for instance, 'Service_OrderFulfillment'. |
 | **Missing Flow Description** | Descriptions play a vital role in documentation. We highly recommend including details about where they are used and their intended purpose. |
 | **Missing Fault Path** | At times, a flow may fail to execute a configured operation as intended. By default, the flow displays an error message to the user and notifies the admin who created the flow via email. However, you can customize this behavior by incorporating a Fault Path. |
 | **Missing Null Handler** | When a Get Records operation doesn't find any data, it returns null. To ensure data validation, utilize a decision element on the operation result variable to check for a non-null result. |
+| **SOQL Query In A Loop** | To prevent exceeding Apex governor limits, it is advisable to consolidate all your SOQL queries at the conclusion of the flow. |
 | **Unconnected Element** | Unconnected elements which are not being used by the Flow should be avoided to keep Flows efficient and maintainable. |
 | **Unused Variable** | To maintain the efficiency and manageability of your Flow, it's advisable to avoid including unconnected variables that are not in use. |
 

package.json

@@ -1,6 +1,6 @@
 {
  "name": "lightning-flow-scanner",
- "version": "2.15.0",
+ "version": "2.16.0",
  "author": "Ruben",
  "bugs": "https://github.com/Force-Config-Control/lightning-flow-scanner-sfdx/issues",
  "dependencies": {
@@ -13,7 +13,7 @@
  "cosmiconfig": "^8.1.3",
  "fs-extra": "^11.1.1",
  "glob": "^7.1.7",
- "lightning-flow-scanner-core": "2.25",
+ "lightning-flow-scanner-core": "2.26",
  "tslib": "^1",
  "xml2js": "^0.4.23"
  },

src/commands/flow/scan.ts

@@ -160,18 +160,18 @@ export default class scan extends SfdxCommand {
  status = 0;
  }
  else {
- if (this.failOn === "error" && (this.errorCounters["error"] || 0) > 0) {
+ if (this.failOn === "error" && this.errorCounters["error"] > 0) {
  status = 1;
  }
- else if (this.failOn === 'warning' &&
- ((this.errorCounters["error"] || 0) > 0)
- || ((this.errorCounters["warning"] || 0) > 0)) {
+ else if (this.failOn === 'warning' && (
+ this.errorCounters["error"]  > 0
+ || this.errorCounters["warning"] > 0)) {
  status = 1;
  }
  else if (this.failOn === 'note' &&
- ((this.errorCounters["error"] || 0) > 0)
- || ((this.errorCounters["warning"] || 0) > 0)
- || ((this.errorCounters["note"] || 0) > 0)) {
+ (this.errorCounters["error"] > 0
+ || this.errorCounters["warning"] > 0
+ || this.errorCounters["note"] > 0)) {
  status = 1;
  }
  }

yarn.lock

@@ -458,9 +458,9 @@
  resolved "https://registry.yarnpkg.com/@types/chai/-/chai-4.2.19.tgz#80f286b515897413c7a35bdda069cc80f2344233"
 
 "@types/chai@^4.2.21":
- version "4.3.10"
- resolved "https://registry.yarnpkg.com/@types/chai/-/chai-4.3.10.tgz#2ad2959d1767edee5b0e4efb1a0cd2b500747317"
- integrity sha512-of+ICnbqjmFCiixUnqRulbylyXQrPqIGf/B3Jax1wIF3DvSheysQxAWvqHhZiW3IQrycvokcLcFQlveGp+vyNg==
+ version "4.3.11"
+ resolved "https://registry.yarnpkg.com/@types/chai/-/chai-4.3.11.tgz#e95050bf79a932cb7305dd130254ccdf9bde671c"
+ integrity sha512-qQR1dr2rGIHYlJulmr8Ioq3De0Le9E4MJ5AiaeAETJJpndT1uUNHsGFK3L/UIu+rbkQSdj8J/w2bCsBZc/Y5fQ==
 
 "@types/glob@^7.1.1":
  version "7.1.3"
@@ -508,9 +508,9 @@
  resolved "https://registry.yarnpkg.com/@types/node/-/node-16.0.0.tgz#067a6c49dc7a5c2412a505628e26902ae967bf6f"
 
 "@types/node@^20.4.5":
- version "20.9.0"
- resolved "https://registry.yarnpkg.com/@types/node/-/node-20.9.0.tgz#bfcdc230583aeb891cf51e73cfdaacdd8deae298"
- integrity sha512-nekiGu2NDb1BcVofVcEKMIwzlx4NjHlcjhoxxKBNLtz15Y1z7MYf549DFvkHSId02Ax6kGwWntIBPC3l/JZcmw==
+ version "20.10.0"
+ resolved "https://registry.yarnpkg.com/@types/node/-/node-20.10.0.tgz#16ddf9c0a72b832ec4fcce35b8249cf149214617"
+ integrity sha512-D0WfRmU9TQ8I9PFx9Yc+EBHw+vSpIub4IDvQivcp26PtPrdMGAq5SDcpXEo/epqa/DXotVpekHiLNTg3iaKXBQ==
  dependencies:
  undici-types "~5.26.4"
 
@@ -2638,10 +2638,10 @@ levn@^0.4.1:
  prelude-ls "^1.2.1"
  type-check "~0.4.0"
 
-lightning-flow-scanner-core@2.25:
- version "2.25.0"
- resolved "https://registry.yarnpkg.com/lightning-flow-scanner-core/-/lightning-flow-scanner-core-2.25.0.tgz#3c11b8e04d5fe3c287fe1310124f38da0768bf30"
- integrity sha512-AktlapWeh9uNaa1BoeBfJ54uGWpPnGWa6z+q8fQumsQHx5xr0bdPpR/B+29RuPC6BxccTUxen4L747n3dMRRAg==
+lightning-flow-scanner-core@2.26:
+ version "2.26.0"
+ resolved "https://registry.yarnpkg.com/lightning-flow-scanner-core/-/lightning-flow-scanner-core-2.26.0.tgz#3b65def0fed760b17cad807e38e71bb4f94b03e5"
+ integrity sha512-daojvhKd5QdmQiu/gVCvsXFA2bVvtR8kHfUkTTFjSrDo8LA8VX//Fdk2CuUZxY5U1Z1MF9v+7cjal01N5hiaBg==
  dependencies:
  "@types/chai" "^4.2.21"
  "@types/node" "^20.4.5"