Fix exiv2 -pR for Sony images (#1805) #1929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
postscript-dev added bug samples makerNote 
Codecov Report
@@ Coverage Diff @@ ## main #1929 +/- ## ========================================== - Coverage 61.16% 61.15% -0.01% ========================================== Files 96 96 Lines 19255 19258 +3 Branches 9862 9863 +1 ========================================== Hits 11777 11777 - Misses 5135 5138 +3 Partials 2343 2343
Continue to review full report at Codecov.
|
kevinbackhouse previously approved these changes Oct 9, 2021
postscript-dev force-pushed the fix_exiv2_-pR branch from 76d1c71 to ba6632d Compare kevinbackhouse previously approved these changes Oct 15, 2021
`exiv2 -pR` failed to process Sony makernotes. Fix checks if makernotes header has Sony string, then uses correct offset. Fix supplied by @clanmills
postscript-dev force-pushed the fix_exiv2_-pR branch from ba6632d to 1535357 Compare 
kevinbackhouse approved these changes Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes #1805