Skip to content

Conversation

@postscript-dev
Copy link
Collaborator

@postscript-dev postscript-dev commented Sep 24, 2021

Only certain camera models are supported.

Changes:

  • Add conditions to Exif.Sony2Fp.AmbientTemperature and Exif.SonyMisc1.CameraTemperature
  • Add Python tests

Source: https://github.com/exiftool/exiftool/blob/master/lib/Image/ExifTool/Sony.pm

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #1926 (4dabfae) into main (e2f3d6d) will decrease coverage by 0.00%.
The diff coverage is 61.53%.

❗ Current head 4dabfae differs from pull request most recent head 5325056. Consider uploading reports for the commit 5325056 to get more accurate results
Impacted file tree graph

@@ Coverage Diff @@ ## main #1926 +/- ## ========================================== - Coverage 61.13% 61.13% -0.01%  ========================================== Files 96 96 Lines 19051 19060 +9 Branches 9728 9739 +11 ========================================== + Hits 11647 11652 +5  - Misses 5090 5091 +1  - Partials 2314 2317 +3 
Impacted Files Coverage Δ
src/sonymn_int.cpp 51.92% <61.53%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2f3d6d...5325056. Read the comment docs.

Check if pretty printing outputs `"n/a"` when used with unsupported camera models.
@postscript-dev postscript-dev self-assigned this Sep 24, 2021
@postscript-dev postscript-dev added enhancement feature / functionality enhancements makerNote Anything related to one of the various supported MakerNote formats prettyPrinter Anything related to the output formatting of a value labels Sep 24, 2021
@postscript-dev postscript-dev changed the title Draft: Add conditions to 2 Sony temperature tags Add conditions to 2 Sony temperature tags Sep 24, 2021
@kevinbackhouse kevinbackhouse merged commit 887acd0 into Exiv2:main Sep 29, 2021
@postscript-dev postscript-dev deleted the fix_sony_temperature_tags branch October 20, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement feature / functionality enhancements makerNote Anything related to one of the various supported MakerNote formats prettyPrinter Anything related to the output formatting of a value

2 participants