Tickets: show Manage links only for completed orders (#1184)

* closes 1160. Co-authored-by: Sebastian Witowski <sebawitowski@yahoo.com>

Author: umgelurgel

README.md

@@ -69,7 +69,7 @@ You can access the admin pages using the `admin` username. You can login to the
 To start a server with the VS Code debugger enabled, run:
 
 ```bash
-$ docker -f docker-compose.yml -f docker-compose-vscode-debugger.yml up
+$ docker-compose -f docker-compose.yml -f docker-compose-vscode-debugger.yml up
 ```
 
 Next, run "Start Debugging" command in VS Code (otherwise, the `docker-compose up`

templates/ep19/bs/cart/_order_summary.html

@@ -4,20 +4,26 @@ <h4>Summary</h4>
  <tr>
  <th>code</th>
  <th>ticket</th>
- <th>&euro;</th>
- <th class='text-right'>Manage</th>
+ {% if order.is_complete %}
+ <th>&euro;</th>
+ <th class='text-right'>Manage</th>
+ {% else %}
+ <th class='text-right'>&euro;</th>
+ {% endif %}
  </tr>
 
  {% for item in order.orderitem_set.all %}
  <tr>
  <td>{{ item.code }}</td>
  <td>{% if item.ticket %}{{ item.ticket }}{% else %}{{ item.description }}{% endif %}</td>
- <td>{{ item.price }}</td>
- {% if item.ticket %}
- <td class='text-right'>
- <a class='btn btn-outline-primary' href='{% url "user_panel:manage_ticket" item.ticket.id %}'>Configure ticket</a>
- <a class='btn btn-outline-primary' href='{% url "user_panel:assign_ticket" item.ticket.id %}'>Assign ticket</a>
- </td>
+ {% if order.is_complete %}
+ <td>{{ item.price }}</td>
+ <td class='text-right'>
+ <a class='btn btn-outline-primary' href='{% url "user_panel:manage_ticket" item.ticket.id %}'>Configure ticket</a>
+ <a class='btn btn-outline-primary' href='{% url "user_panel:assign_ticket" item.ticket.id %}'>Assign ticket</a>
+ </td>
+ {% else %}
+ <td class='text-right'>{{ item.price }}</td>
  {% endif %}
 
  </tr>

tests/test_cart.py

@@ -378,6 +378,16 @@ def test_cart_computes_discounts_correctly(db, user_client):
  == (order_ticket_count * coupon_fare.price) * Decimal((100 - percent_discount)/100))
 
 
+@mark.xfail
+def test_manage_and_assign_ticket_urls_not_shown_in_step_3(db):
+ assert False
+
+
+@mark.xfail
+def test_manage_and_assign_ticket_urls_not_shown_in_step_4(db):
+ assert False
+
+
 @mark.xfail
 def test_cart_only_allows_to_buy_less_than_max_number_of_tickets(db):
  # TODO: This is now only enforced on the frontend - the backend implementation is missing