Merge pull request #345 from remcohaszing/remove-rulesconfig

Remove default configurations

Author: EmmanuelDemey

README.md

@@ -104,7 +104,7 @@ Users may use the shareable [eslint-config-angular](https://github.com/dustinspe
  "angular/controller-as": 0,
  "angular/controller-as-route": 0,
  "angular/controller-as-vm": [0, "vm"],
- "angular/controller-name": [0, "/[A-Z].*Controller$/"],
+ "angular/controller-name": 0,
  "angular/deferred": 0,
  "angular/definedundefined": 0,
  "angular/di": [0, "function"],

index.js

@@ -7,7 +7,7 @@ rulesConfiguration.addRule('component-limit', [0, 1]);
 rulesConfiguration.addRule('controller-as', 0);
 rulesConfiguration.addRule('controller-as-route', 0);
 rulesConfiguration.addRule('controller-as-vm', [0, 'vm']);
-rulesConfiguration.addRule('controller-name', [0, /[A-Z].*Controller$/]);
+rulesConfiguration.addRule('controller-name', 0);
 rulesConfiguration.addRule('deferred', 0);
 rulesConfiguration.addRule('definedundefined', 0);
 rulesConfiguration.addRule('di', [0, 'function']);

rules/controller-name.js

@@ -18,13 +18,9 @@ module.exports = function(context) {
  return {
 
  CallExpression: function(node) {
- var prefix = context.options[0];
+ var prefix = context.options[0] || '/[A-Z].*Controller$/';
  var convertedPrefix; // convert string from JSON .eslintrc to regex
 
- if (prefix === undefined) {
- return;
- }
-
  convertedPrefix = utils.convertPrefixToRegex(prefix);
 
  var callee = node.callee;
@@ -55,3 +51,9 @@ module.exports = function(context) {
  }
  };
 };
+
+module.exports.schema = [
+ {
+ type: 'string'
+ }
+];

test/controller-name.js

@@ -19,13 +19,10 @@ eslintTester.run('controller-name', rule, {
  options: ['eslint']
  }, {
  code: 'app.controller("eslintController", function() {});',
- options: [/^eslint/]
- }, {
- code: 'app.controller("eslintController", function() {});',
- options: [undefined]
+ options: ['/^eslint/']
  }, {
  code: 'app.controller("EslintController", function() {});',
- options: [/[A-Z].*Controller$/]
+ options: ['/[A-Z].*Controller$/']
  }, {
  code: 'app.controller("EslintController", function() {});',
  options: ['/[A-Z].*Controller$/']
@@ -49,17 +46,17 @@ eslintTester.run('controller-name', rule, {
  },
  {
  code: 'app.controller("Controller", function() {});',
- options: [/^eslint/],
+ options: ['/^eslint/'],
  errors: [{message: 'The Controller controller should follow this pattern: /^eslint/'}]
  },
  {
  code: 'app.controller("customers", function() {});',
- options: [/[A-Z].*Controller$/],
+ options: ['/[A-Z].*Controller$/'],
  errors: [{message: 'The customers controller should follow this pattern: /[A-Z].*Controller$/'}]
  },
  {
  code: 'app.controller("customersController", function() {});',
- options: [/[A-Z].*Controller$/],
+ options: ['/[A-Z].*Controller$/'],
  errors: [{message: 'The customersController controller should follow this pattern: /[A-Z].*Controller$/'}]
  }, {
  code: 'app.controller("eslintController", function() {});',