Skip to content

Commit 5851f85

Browse files
committed
android fixes
1 parent 661462a commit 5851f85

File tree

4 files changed

+11
-4
lines changed

4 files changed

+11
-4
lines changed

android/src/main/java/com/dylanvann/fastimage/FastImageOkHttpProgressGlideModule.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
@GlideModule
3333
public class FastImageOkHttpProgressGlideModule extends LibraryGlideModule {
3434

35-
private static DispatchingProgressListener progressListener = new DispatchingProgressListener();
35+
private static final DispatchingProgressListener progressListener = new DispatchingProgressListener();
3636

3737
@Override
3838
public void registerComponents(

android/src/main/java/com/dylanvann/fastimage/FastImageSource.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public class FastImageSource extends ImageSource {
1717
private static final String ANDROID_RESOURCE_SCHEME = "android.resource";
1818
private static final String ANDROID_CONTENT_SCHEME = "content";
1919
private static final String LOCAL_FILE_SCHEME = "file";
20-
private Headers mHeaders;
20+
private final Headers mHeaders;
2121
private Uri mUri;
2222

2323
public static boolean isBase64Uri(Uri uri) {

android/src/main/java/com/dylanvann/fastimage/FastImageViewModule.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
import android.app.Activity;
44

5+
import androidx.annotation.NonNull;
6+
57
import com.bumptech.glide.Glide;
68
import com.bumptech.glide.load.model.GlideUrl;
79
import com.facebook.react.bridge.Promise;
@@ -20,6 +22,7 @@ class FastImageViewModule extends ReactContextBaseJavaModule {
2022
super(reactContext);
2123
}
2224

25+
@NonNull
2326
@Override
2427
public String getName() {
2528
return REACT_CLASS;
Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package com.dylanvann.fastimage;
22

3+
import androidx.annotation.NonNull;
4+
35
import com.facebook.react.ReactPackage;
46
import com.facebook.react.bridge.NativeModule;
57
import com.facebook.react.bridge.ReactApplicationContext;
@@ -9,13 +11,15 @@
911
import java.util.List;
1012

1113
public class FastImageViewPackage implements ReactPackage {
14+
@NonNull
1215
@Override
13-
public List<NativeModule> createNativeModules(ReactApplicationContext reactContext) {
16+
public List<NativeModule> createNativeModules(@NonNull ReactApplicationContext reactContext) {
1417
return Collections.<NativeModule>singletonList(new FastImageViewModule(reactContext));
1518
}
1619

20+
@NonNull
1721
@Override
18-
public List<ViewManager> createViewManagers(ReactApplicationContext reactContext) {
22+
public List<ViewManager> createViewManagers(@NonNull ReactApplicationContext reactContext) {
1923
return Collections.<ViewManager>singletonList(new FastImageViewManager());
2024
}
2125
}

0 commit comments

Comments
 (0)