Skip to content

Request canceled middleware #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 9, 2022
Merged

Request canceled middleware #530

merged 3 commits into from
Nov 9, 2022

Conversation

@ariellourenco
Copy link
Contributor

@ariellourenco ariellourenco commented Oct 13, 2022

This PR address some small unit tests issues for the RequestCanceledMiddleware as well as improves its test coverage as noted below:

  • Removes unrelated unit tests for InvokeAsync method.
  • Refactor the InvokeAsync_NullContext_ThrowsArgumentNullExceptionAsync unit test.
  • Add a unit test to ensure we are able to handle TaskCanceledException.
  • Assert if a new event has been added to the current Activity.
@github-actions github-actions bot added the maintenance Pull requests that perform maintenance on the project but add no features or bug fixes. label Oct 13, 2022
@RehanSaeed RehanSaeed added the patch Pull requests requiring a patch version update according to semantic versioning. label Oct 17, 2022
@RehanSaeed
Copy link
Member

RehanSaeed commented Oct 17, 2022

Thanks @ariellourenco!
@RehanSaeed RehanSaeed merged commit 526bebc into Dotnet-Boxed:main Nov 9, 2022
@ariellourenco ariellourenco deleted the requestCanceledMiddleware branch November 9, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Pull requests that perform maintenance on the project but add no features or bug fixes. patch Pull requests requiring a patch version update according to semantic versioning.

2 participants

@ariellourenco @RehanSaeed