Skip to content

feat: Add dotnet uninstall command #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 4, 2021
Merged

feat: Add dotnet uninstall command #358

merged 3 commits into from
Oct 4, 2021

Conversation

@johanndev
Copy link
Contributor

@johanndev johanndev commented Oct 1, 2021

  • Adds the DotnetNew.UninstallAsync() method to clean up dotnet template installations between test runs.
  • Add missing exception annotations
  • Move the call to ProcessExtensions.StartAsync into a private method

Fixes: #357
@johanndev
feat: Add dotnet uninstall command
f31ee29 
- Adds the `DotnetNew.UninstallAsync()` method to clean up dotnet template installations between test runs. - Add missing exception annotations - Move the call to `ProcessExtensions.StartAsync` into a private method Fixes: #357
RehanSaeed
RehanSaeed requested changes Oct 1, 2021
View reviewed changes
Copy link
Member

@RehanSaeed RehanSaeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising. A couple of very small comments made.
@johanndev
Incoporate PR feedback
d2a9dba 
- Split argument checking into null check and separate length check - Extract GetProjectFilePath method
@johanndev
Fix wrong argument order on ArgumentExceptions
9fe571f
@RehanSaeed RehanSaeed added enhancement Issues or pull requests adding an enhancement. minor Pull requests requiring a minor version update according to semantic versioning. labels Oct 4, 2021
@RehanSaeed
Copy link
Member

RehanSaeed commented Oct 4, 2021

Looks good. Thanks again for the PR.
@RehanSaeed RehanSaeed merged commit 01dc955 into Dotnet-Boxed:main Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Issues or pull requests adding an enhancement. minor Pull requests requiring a minor version update according to semantic versioning.

2 participants

@johanndev @RehanSaeed