refactor: add deref_by_slicing clippy style and readability lint (#979)

> Checks for slicing expressions which are equivalent to dereferencing the value. > Some people may prefer to dereference rather than slice.

Author: RRRadicalEdward

Cargo.toml

@@ -121,6 +121,7 @@ semicolon_outside_block = "warn" # With semicolon-outside-block-ignore-multiline
 clone_on_ref_ptr = "warn"
 cloned_instead_of_copied = "warn"
 pub_without_shorthand = "warn"
+deref_by_slicing = "warn"
 multiple_inherent_impl = "warn"
 map_with_unused_argument_over_ranges = "warn"
 trait_duplication_in_bounds = "warn"

crates/ironrdp-testsuite-core/tests/graphics/rlgr.rs

@@ -19,7 +19,7 @@ fn encode_works_with_rlgr3() {
  let output_len = expected.len();
  let mut output = vec![0u8; output_len];
  encode(mode, input, &mut output).unwrap();
- assert_eq!(&expected[..], &output[..]);
+ assert_eq!(*expected, &output);
  }
 }
 
@@ -41,7 +41,7 @@ fn decode_works_with_rlgr3() {
  let mut output = vec![0i16; expected.len() * output_len];
  for (i, (input, expected)) in input.iter().zip(expected.iter()).enumerate() {
  decode(mode, input, &mut output[i * output_len..(i + 1) * output_len]).unwrap();
- assert_eq!(&expected[..], &output[i * 4096..(i + 1) * 4096]);
+ assert_eq!(**expected, output[i * 4096..(i + 1) * 4096]);
  }
 }
 

crates/ironrdp-testsuite-core/tests/pdu/pointer.rs

@@ -29,7 +29,7 @@ fn expect_pointer_png(pointer: &DecodedPointer, expected_file_path: &str) {
  }
 
  let png_buffer = std::fs::read(path).unwrap();
- let mut png_reader = png::Decoder::new(Cursor::new(&png_buffer[..])).read_info().unwrap();
+ let mut png_reader = png::Decoder::new(Cursor::new(&png_buffer)).read_info().unwrap();
  let mut png_reader_buffer = vec![0u8; png_reader.output_buffer_size().unwrap()];
  let frame_size = png_reader.next_frame(&mut png_reader_buffer).unwrap().buffer_size();
  let expected = &png_reader_buffer[..frame_size];

crates/ironrdp-web/src/network_client.rs

@@ -20,7 +20,7 @@ impl AsyncNetworkClient for WasmNetworkClient {
 
  match &network_request.protocol {
  NetworkProtocol::Http | NetworkProtocol::Https => {
- let body = js_sys::Uint8Array::from(&network_request.data[..]);
+ let body = js_sys::Uint8Array::from(network_request.data.as_slice());
 
  let response = gloo_net::http::Request::post(network_request.url.as_str())
  .header("keep-alive", "true")