fix(web): fix this.lastSentClipboardData being nulled (#992)

```js await this.remoteDesktopService.onClipboardChanged(...) ``` Consumes the clipboard data we pass, so we need to clone the data to prevent `this.lastSentClipboardData` from being null.

Author: RRRadicalEdward

crates/iron-remote-desktop/src/lib.rs

@@ -159,8 +159,8 @@ macro_rules! make_bridge {
  }
 
  #[wasm_bindgen(js_name = onClipboardPaste)]
- pub async fn on_clipboard_paste(&self, content: ClipboardData) -> Result<(), IronError> {
- $crate::Session::on_clipboard_paste(&self.0, content.0)
+ pub async fn on_clipboard_paste(&self, content: &ClipboardData) -> Result<(), IronError> {
+ $crate::Session::on_clipboard_paste(&self.0, &content.0)
  .await
  .map_err(IronError)
  }

crates/iron-remote-desktop/src/session.rs

@@ -84,7 +84,7 @@ pub trait Session {
 
  fn on_clipboard_paste(
  &self,
- content: Self::ClipboardData,
+ content: &Self::ClipboardData,
  ) -> impl core::future::Future<Output = Result<(), Self::Error>>;
 
  fn resize(

crates/ironrdp-web/src/session.rs

@@ -800,10 +800,10 @@ impl iron_remote_desktop::Session for Session {
  Ok(())
  }
 
- async fn on_clipboard_paste(&self, content: Self::ClipboardData) -> Result<(), Self::Error> {
+ async fn on_clipboard_paste(&self, content: &Self::ClipboardData) -> Result<(), Self::Error> {
  self.input_events_tx
  .unbounded_send(RdpInputEvent::ClipboardBackend(
- WasmClipboardBackendMessage::LocalClipboardChanged(content),
+ WasmClipboardBackendMessage::LocalClipboardChanged(content.clone()),
  ))
  .context("Send clipboard backend event")?;
 

web-client/iron-remote-desktop/src/services/clipboard.service.ts

@@ -149,7 +149,6 @@ export class ClipboardService {
 
  if (!clipboardData.isEmpty()) {
  this.lastSentClipboardData = clipboardData;
- // TODO(Fix): onClipboardChanged takes an ownership over clipboardData, so lastSentClipboardData will be nullptr.
  await this.remoteDesktopService.onClipboardChanged(clipboardData);
  }
  }
@@ -192,7 +191,6 @@ export class ClipboardService {
 
  // This callback is required to send initial clipboard state if available.
  private onForceClipboardUpdate() {
- // TODO(Fix): lastSentClipboardData is nullptr.
  try {
  if (this.lastSentClipboardData) {
  this.remoteDesktopService.onClipboardChanged(this.lastSentClipboardData);
@@ -313,7 +311,6 @@ export class ClipboardService {
 
  if (!clipboardData.isEmpty()) {
  this.lastSentClipboardData = clipboardData;
- // TODO(Fix): onClipboardChanged takes an ownership over clipboardData, so lastSentClipboardData will be nullptr.
  await this.remoteDesktopService.onClipboardChanged(clipboardData);
  }
  }
@@ -406,7 +403,6 @@ export class ClipboardService {
 
  if (!clipboardData.isEmpty()) {
  this.lastSentClipboardData = clipboardData;
- // TODO(Fix): onClipboardChanged takes an ownership over clipboardData, so lastSentClipboardData will be nullptr.
  await this.remoteDesktopService.onClipboardChanged(clipboardData);
  }
  }