Add proper loggin, remove timeout, send console log with error

Author: DavidToca

webpack_loader/loader.py

@@ -1,12 +1,15 @@
 import json
 import time
+import logging
 
 from django.conf import settings
 from django.contrib.staticfiles.storage import staticfiles_storage
 
 from .exceptions import WebpackError, WebpackLoaderBadStatsError
 from .config import load_config
 
+logger = logging.getLogger('webpack_loader')
+
 
 class WebpackLoader(object):
  _assets = {}
@@ -52,13 +55,18 @@ def get_chunk_url(self, chunk):
 
  def get_bundle(self, bundle_name):
  assets = self.get_assets()
+ logger.debug("[{}][{}] get_bundle".format(
+ bundle_name, assets.get('status')))
 
  if settings.DEBUG:
- # poll when debugging and block request until bundle is compiled
- # TODO: support timeouts
- while assets['status'] == 'compiling':
- time.sleep(self.config['POLL_INTERVAL'])
- assets = self.get_assets()
+ if assets['status'] == 'compiling':
+ if 'file' not in assets:
+ assets['file'] = ''
+
+ error = u"{file} is compiling ".format(**assets)
+ logger.error("[{}][ERROR] {}".format(
+ bundle_name, error))
+ raise IOError(error)
 
  if assets.get('status') == 'done':
  chunks = assets['chunks'][bundle_name]

webpack_loader/templatetags/webpack_loader.py

@@ -1,11 +1,12 @@
 from django import template
 from django.conf import settings
 from django.utils.safestring import mark_safe
+import logging
 
 from ..utils import get_loader
 
 register = template.Library()
-
+logger = logging.getLogger('webpack_loader')
 
 def filter_by_extension(bundle, extension):
  '''Return only files with the given extension'''
@@ -37,9 +38,13 @@ def _get_bundle(bundle_name, extension, config):
 
 @register.simple_tag
 def render_bundle(bundle_name, extension=None, config='DEFAULT'):
+ logger.info("[{}] is called for rendering".format(bundle_name))
  try:
  return render_as_tags(_get_bundle(bundle_name, extension, config))
  except (IOError, KeyError) as e:
+ logger.error("[{}] failed rendering, reason: {}".format(
+ bundle_name, e)
+ )
  return '<script>console.error("{} - {}");</script>'.format(
  bundle_name,
  e