Merge pull request #31 from CrashOps/0.3.12

v0.3.12 - bug fixes

Author: CrashOps

CrashOps.podspec

@@ -16,7 +16,7 @@ Pod::Spec.new do |s|
  #
 
  s.name = "CrashOps"
- s.version = "0.3.11"
+ s.version = "0.3.12"
  s.summary = "CrashOps monitors your app's stability and vulnerability."
 
  # This description is used to generate tags and improve search results.

CrashOps/AppleFormatter/AppleCrashReportGenerator.m

@@ -1011,6 +1011,10 @@ + (NSString *) generateIpsFile:(NSURL *)originalJsonReportPath {
 
  NSString *filePath = [[CrashOpsController ipsFilesLibraryPath] stringByAppendingPathComponent: [NSString stringWithFormat:@"%@.ips", fileName]];
 
+ if (!filePath) {
+ return filePath;
+ }
+
  if ([[NSFileManager defaultManager] fileExistsAtPath: filePath]) {
  return filePath;
  }

CrashOps/Facade/CrashOps.m

@@ -29,7 +29,6 @@ @interface CrashOps()
 @implementation CrashOps
 
 @synthesize appKey;
-@synthesize metadata;
 @synthesize isEnabled;
 @synthesize isTracingScreens;
 
@@ -43,7 +42,7 @@ - (instancetype)initWithCoder:(NSCoder *)coder {
  if (self) {
  isEnabled = YES;
  appKey = @"";
- metadata = [NSMutableDictionary new];
+ _metadata = [NSMutableDictionary new];
  }
 
  CrashOps* sdkInstance;
@@ -63,9 +62,9 @@ - (void)deleteOldReports {
  [[KSCrash sharedInstance] deleteAllReports];
 }
 
-- (void)setMetadata:(NSMutableDictionary *)metadata {
+- (void)setMetadata:(NSMutableDictionary *) metadata {
  if ([metadata isKindOfClass: [NSDictionary class]]) {
- self.metadata = metadata;
+ _metadata = metadata;
  }
 }
 
@@ -86,7 +85,7 @@ +(BOOL)isRunningOnDebugMode {
 }
 
 + (NSString *)sdkVersion {
- return @"0.3.11";
+ return @"0.3.12";
 }
 
 - (void) crash {
@@ -153,7 +152,7 @@ +(void)initialize {
 @end
 
 //! Project version number for CrashOps.
-//double CrashOpsVersionNumber = 0.0311;
+//double CrashOpsVersionNumber = 0.0312;
 
 //! Project version string for CrashOps.
-//const unsigned char CrashOpsVersionString[] = "0.03.11";
+//const unsigned char CrashOpsVersionString[] = "0.03.12";

CrashOps/Logic/CrashOpsController.m

@@ -976,6 +976,31 @@ + (NSMutableDictionary *) addCrashOpsConstantFields:(NSDictionary *) reportJson
 
  NSMutableDictionary *reportCopy = [reportJson mutableCopy];
  reportCopy[@"devicePlatform"] = @"ios";
+ NSMutableDictionary *system = [reportCopy[@"system"] mutableCopy];
+ if (!system) {
+ system = [NSMutableDictionary new];
+ }
+
+ NSDictionary *appInfoDictionary = [[NSBundle mainBundle] infoDictionary];
+ CODebugLog([appInfoDictionary description]);
+
+ NSString *appBuildNumberString;
+ if (appInfoDictionary[@"CFBundleVersion"]) {
+ NSInteger appBuildNumber = [appInfoDictionary[@"CFBundleVersion"] intValue];
+ appBuildNumberString = [NSString stringWithFormat:@"%ld", (long) appBuildNumber];
+ }
+ 
+ NSString *appVersionString;
+ if (appInfoDictionary[@"CFBundleShortVersionString"]) {
+ appVersionString = [appInfoDictionary[@"CFBundleShortVersionString"] description];
+ }
+
+ [system co_setOptionalObject: NSBundle.mainBundle.bundleIdentifier forKey:@"CFBundleIdentifier"];
+ [system co_setOptionalObject: appVersionString forKey:@"CFBundleShortVersionString"];
+ [system co_setOptionalObject: appBuildNumberString forKey:@"CFBundleVersion"];
+
+ reportCopy[@"system"] = system;
+
  reportCopy[@"crashOpsSdkVersion"] = [CrashOps sdkVersion]; //[NSString stringWithCString:CrashOpsVersionString encoding: NSUTF8StringEncoding];
  reportCopy[@"buildMode"] = [CrashOps isRunningOnDebugMode] ? @"DEBUG" : @"RELEASE";
 
@@ -1036,14 +1061,20 @@ -(void) onEventFileCreated:(NSString *) eventId {
  NSLog(@"New event ID saved: %@", eventId);
 
  NSString *eventIdFile = [[self eventsFolderPath] stringByAppendingPathComponent: eventId];
+ if (eventIdFile) {
+ NSData *eventIdData = [appSessionId dataUsingEncoding: NSUTF8StringEncoding];
+ [eventIdData writeToFile: eventIdFile options: NSDataWritingAtomic error: nil];
+ } else {
+ [CrashOpsController logInternalError: [NSString stringWithFormat:@"Failed to save session ID: %@", appSessionId]];
+ }
 
- NSData *eventIdData = [appSessionId dataUsingEncoding: NSUTF8StringEncoding];
- [eventIdData writeToFile: eventIdFile options: NSDataWritingAtomic error: nil];
- 
  NSString *sessionIdFile = [[self sessionsFolderPath] stringByAppendingPathComponent: appSessionId];
- 
- NSData *sessionIdData = [eventId dataUsingEncoding: NSUTF8StringEncoding];
- [sessionIdData writeToFile: sessionIdFile options: NSDataWritingAtomic error: nil];
+ if (sessionIdFile) {
+ NSData *sessionIdData = [eventId dataUsingEncoding: NSUTF8StringEncoding];
+ [sessionIdData writeToFile: sessionIdFile options: NSDataWritingAtomic error: nil];
+ } else {
+ [CrashOpsController logInternalError: [NSString stringWithFormat:@"Failed to save event ID: %@", eventId]];
+ }
 }
 
 -(void) handleException:(NSException *) exception {
@@ -1085,19 +1116,26 @@ - (BOOL) logError:(NSDictionary *) errorDetails {
  NSString *nowString = [CrashOpsController stringFromDate: now withFormat: @"yyyy-MM-dd-HH-mm-ss-SSS_ZZZ"];
 
  NSString *filePath = [[self errorsFolderPath] stringByAppendingPathComponent: [NSString stringWithFormat:@"ios_error_%@_%@.log", nowString, [[NSUUID UUID] UUIDString]]];
- 
+ if (!filePath) {
+ return;
+ }
+
  NSArray *breadcrumbs = [ScreenTracer tracesReportForSessionId: sessionId];
 
  NSDictionary *jsonDictionary = @{@"errorDetails": errorDetails,
- @"report":@{@"id": [NSNumber numberWithInteger: timestamp],
- @"time": nowString},
+ @"report":@{@"id": [[NSUUID UUID] UUIDString],
+ @"timestamp": [NSNumber numberWithInteger: timestamp],
+ @"time": nowString
+ },
  //@"details": [self generateReport: [NSException exceptionWithName:@"Error" reason:@"" userInfo:@{@"isFatal": NO}]],
  @"details": [self generateReport: nil],
  @"screenTraces": breadcrumbs,
  @"isFatal": @NO
  };
+
+ NSMutableDictionary *crashOpsDictionary = [CrashOpsController addCrashOpsConstantFields: jsonDictionary];
 
- NSData *errorData = [CrashOpsController toJsonData: jsonDictionary];
+ NSData *errorData = [CrashOpsController toJsonData: crashOpsDictionary];
 
  NSError *error;
  BOOL didSave = [errorData writeToFile: filePath options: NSDataWritingAtomic error: &error];
@@ -1362,10 +1400,14 @@ - (void) flushToDisk:(ScreenDetails *) screenDetails {
  [[self coGlobalOperationQueue] addOperationWithBlock:^{
  NSUInteger timestamp = screenDetails.timestamp;
  NSString *filePath = [[[CrashOpsController shared] currentSessionTracesFolderPath] stringByAppendingPathComponent: [NSString stringWithFormat:@"%lu.log", (unsigned long) timestamp]];
+ BOOL didSave = NO;
+
+ if (filePath) {
+ NSData *traceData = [[CrashOpsController toJsonString: [screenDetails toDictionary]] dataUsingEncoding: NSUTF8StringEncoding];
 
- NSData *traceData = [[CrashOpsController toJsonString: [screenDetails toDictionary]] dataUsingEncoding: NSUTF8StringEncoding];
+ didSave = [traceData writeToFile: filePath options: NSDataWritingAtomic error: nil];
+ }
 
- BOOL didSave = [traceData writeToFile: filePath options: NSDataWritingAtomic error: nil];
  if (!didSave) {
  [CrashOpsController logInternalError: [NSString stringWithFormat:@"Failed to flush screen details to disk. Screen details: %@", screenDetails]];
  }

README.md

@@ -12,7 +12,7 @@ CrashOps lets you monitor your app's stability and vulnerability by giving you e
 You want to add `pod 'CrashOps'` similar to the following to your Podfile:
 ```
 target 'MyApp' do
- pod 'CrashOps', '0.3.11'
+ pod 'CrashOps', '0.3.12'
 end
 ```
 Then run a `pod install` in your terminal, or from CocoaPods app.