Skip to content
This repository was archived by the owner on Jan 13, 2023. It is now read-only.

Conversation

@lrog
Copy link
Contributor

@lrog lrog commented Nov 19, 2018

Minor changes, mostly for ease of use when defining job configuration:

  • set localParitioning profile to be active by default one when not set.
  • minor polishing of printing exception stack trace in Main.
    In any case, we are also planning to deprecate the master-slave mode which uses remotePartitioning, hence the localPartitioning should be the default one.
…or polishing of printing exception stack trace in Main
@lrog lrog requested a review from afolarin November 19, 2018 12:43
lrog added 2 commits November 19, 2018 16:24
…" fields for the Document model will be only obligatory when using "docman" profile -- they are used only for document row mapper, for metadata info
@lrog
Copy link
Contributor Author

lrog commented Nov 20, 2018

The last two commits make setting source.srcTableName, source.srcColumnFieldName and source.primaryKeyFieldName properties optional. The information supplied by these properties was used only within docman profile (deprecated) -- when trying to read documents, possibly form the filesystem, and reading the info from the metadata table.
Making these properties optional for common use-cases and required only in docman profile will simplify the usage as these columns won't be needed in the source DB table.

afolarin and others added 2 commits November 20, 2018 16:57
Co-Authored-By: lrog <lrog@users.noreply.github.com>
@lrog lrog merged commit 4f23cb3 into dev Nov 21, 2018
@lrog lrog deleted the refactor-properties branch November 29, 2018 15:50
vladd-bit pushed a commit that referenced this pull request Nov 10, 2021
set "localParitioning" scheme to be the default one when not set
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants