Use dedicated PHPUnit assertions (#4950)

Author: carusogabriel

tests/unit/Codeception/Module/TestsForWeb.php

@@ -1042,10 +1042,10 @@ public function testSubmitForm()
  $form = data::get('form');
  $this->assertEquals('Davert', $form['name']);
  $this->assertEquals('Is Codeception maintainer', $form['description']);
- $this->assertFalse(isset($form['disabled_fieldset']));
- $this->assertFalse(isset($form['disabled_fieldset_textarea']));
- $this->assertFalse(isset($form['disabled_fieldset_select']));
- $this->assertFalse(isset($form['disabled_field']));
+ $this->assertArrayNotHasKey('disabled_fieldset', $form);
+ $this->assertArrayNotHasKey('disabled_fieldset_textarea', $form);
+ $this->assertArrayNotHasKey('disabled_fieldset_select', $form);
+ $this->assertArrayNotHasKey('disabled_field', $form);
  $this->assertEquals('kill_all', $form['action']);
  }
 
@@ -1209,8 +1209,8 @@ public function testSubmitFormWithTwoSubmitButtonsSubmitsCorrectValue()
  $this->module->seeElement("#button2");
  $this->module->click("#button2");
  $form = data::get('form');
- $this->assertTrue(isset($form['button2']));
- $this->assertTrue(isset($form['username']));
+ $this->assertArrayHasKey('button2', $form);
+ $this->assertArrayHasKey('username', $form);
  $this->assertEquals('value2', $form['button2']);
  $this->assertEquals('fred', $form['username']);
  }
@@ -1224,8 +1224,8 @@ public function testSubmitFormWithTwoSubmitButtonsSubmitsCorrectValueAfterFillFi
  $this->module->fillField("username", "bob");
  $this->module->click("#button2");
  $form = data::get('form');
- $this->assertTrue(isset($form['button2']));
- $this->assertTrue(isset($form['username']));
+ $this->assertArrayHasKey('button2', $form);
+ $this->assertArrayHasKey('username', $form);
  $this->assertEquals('value2', $form['button2']);
  $this->assertEquals('bob', $form['username']);
  }
@@ -1268,8 +1268,8 @@ public function testSubmitFormWithDefaultRadioAndCheckboxValues()
  'test' => 'value'
  ));
  $form = data::get('form');
- $this->assertTrue(isset($form['checkbox1']), 'Checkbox value not sent');
- $this->assertTrue(isset($form['radio1']), 'Radio button value not sent');
+ $this->assertArrayHasKey('checkbox1', $form, 'Checkbox value not sent');
+ $this->assertArrayHasKey('radio1', $form, 'Radio button value not sent');
  $this->assertEquals('testing', $form['checkbox1']);
  $this->assertEquals('to be sent', $form['radio1']);
  }
@@ -1281,15 +1281,15 @@ public function testSubmitFormCheckboxWithBoolean()
  'checkbox1' => true
  ));
  $form = data::get('form');
- $this->assertTrue(isset($form['checkbox1']), 'Checkbox value not sent');
+ $this->assertArrayHasKey('checkbox1', $form, 'Checkbox value not sent');
  $this->assertEquals('testing', $form['checkbox1']);
 
  $this->module->amOnPage('/form/example16');
  $this->module->submitForm('form', array(
  'checkbox1' => false
  ));
  $form = data::get('form');
- $this->assertFalse(isset($form['checkbox1']), 'Checkbox value sent');
+ $this->assertArrayNotHasKey('checkbox1', $form, 'Checkbox value sent');
  }
 
  public function testSubmitFormWithCheckboxesWithoutValue()
@@ -1320,7 +1320,7 @@ public function testSubmitFormWithButtons()
  isset($form['button1']) || isset($form['button2']) || isset($form['button4']),
  'Button values for buttons 1, 2 and 4 should not be set'
  );
- $this->assertTrue(isset($form['button3']), 'Button value for button3 should be set');
+ $this->assertArrayHasKey('button3', $form, 'Button value for button3 should be set');
  $this->assertEquals($form['button3'], 'third', 'Button value for button3 should equal third');
 
  $this->module->amOnPage('/form/form_with_buttons');
@@ -1332,7 +1332,7 @@ public function testSubmitFormWithButtons()
  isset($form['button1']) || isset($form['button2']) || isset($form['button3']),
  'Button values for buttons 1, 2 and 3 should not be set'
  );
- $this->assertTrue(isset($form['button4']), 'Button value for button4 should be set');
+ $this->assertArrayHasKey('button4', $form, 'Button value for button4 should be set');
  $this->assertEquals($form['button4'], 'fourth', 'Button value for button4 should equal fourth');
  }
 
@@ -1441,8 +1441,8 @@ public function testSubmitAdjacentForms()
  $this->module->amOnPage('/form/submit_adjacentforms');
  $this->module->submitForm('#form-2', []);
  $data = data::get('form');
- $this->assertTrue(isset($data['second-field']));
- $this->assertFalse(isset($data['first-field']));
+ $this->assertArrayHasKey('second-field', $data);
+ $this->assertArrayNotHasKey('first-field', $data);
  $this->assertEquals('Killgore Trout', $data['second-field']);
  }
 
@@ -1453,17 +1453,17 @@ public function testSubmitAdjacentFormsByButton()
  $this->module->fillField('second-field', 'Second');
  $this->module->click('#submit1');
  $data = data::get('form');
- $this->assertTrue(isset($data['first-field']));
- $this->assertFalse(isset($data['second-field']));
+ $this->assertArrayHasKey('first-field', $data);
+ $this->assertArrayNotHasKey('second-field', $data);
  $this->assertEquals('First', $data['first-field']);
 
  $this->module->amOnPage('/form/submit_adjacentforms');
  $this->module->fillField('first-field', 'First');
  $this->module->fillField('second-field', 'Second');
  $this->module->click('#submit2');
  $data = data::get('form');
- $this->assertFalse(isset($data['first-field']));
- $this->assertTrue(isset($data['second-field']));
+ $this->assertArrayNotHasKey('first-field', $data);
+ $this->assertArrayHasKey('second-field', $data);
  $this->assertEquals('Second', $data['second-field']);
  }