Skip to content

Commit aa46b5d

Browse files
committed
Fix Acknowledgements and animation on git hover
- Animate hover on git hash in About view - Add sort for acknowledgements view - Add a regex parser for CodeEdit (filters out inbuilt packages)
1 parent c8d61e8 commit aa46b5d

File tree

6 files changed

+23
-19
lines changed

6 files changed

+23
-19
lines changed

CodeEdit.xcodeproj/project.pbxproj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@
8686
D7E201BD27EA00E200CB86D0 /* FindNavigatorResultFileItem.swift in Sources */ = {isa = PBXBuildFile; fileRef = D7E201BC27EA00E200CB86D0 /* FindNavigatorResultFileItem.swift */; };
8787
D7F72DEB27EA3574000C3064 /* Search in Frameworks */ = {isa = PBXBuildFile; productRef = D7F72DEA27EA3574000C3064 /* Search */; };
8888
DE6F77872813625500D00A76 /* TabBarDivider.swift in Sources */ = {isa = PBXBuildFile; fileRef = DE6F77862813625500D00A76 /* TabBarDivider.swift */; };
89-
FDF7C12227FAEA860039BA76 /* Package.resolved in Resources */ = {isa = PBXBuildFile; fileRef = FDF7C12127FAEA860039BA76 /* Package.resolved */; };
89+
FD6A3D3D2817C13B008BCF11 /* Package.resolved in Resources */ = {isa = PBXBuildFile; fileRef = FD6A3D3C2817C13B008BCF11 /* Package.resolved */; };
9090
/* End PBXBuildFile section */
9191

9292
/* Begin PBXContainerItemProxy section */
@@ -183,8 +183,8 @@
183183
D7E201B127E8D50000CB86D0 /* FindNavigatorModeSelector.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FindNavigatorModeSelector.swift; sourceTree = "<group>"; };
184184
D7E201B327E9989900CB86D0 /* FindNavigatorResultList.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FindNavigatorResultList.swift; sourceTree = "<group>"; };
185185
D7E201BC27EA00E200CB86D0 /* FindNavigatorResultFileItem.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FindNavigatorResultFileItem.swift; sourceTree = "<group>"; };
186-
FDF7C12127FAEA860039BA76 /* Package.resolved */ = {isa = PBXFileReference; lastKnownFileType = text; path = Package.resolved; sourceTree = SOURCE_ROOT; };
187186
DE6F77862813625500D00A76 /* TabBarDivider.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TabBarDivider.swift; sourceTree = "<group>"; };
187+
FD6A3D3C2817C13B008BCF11 /* Package.resolved */ = {isa = PBXFileReference; lastKnownFileType = file; path = Package.resolved; sourceTree = SOURCE_ROOT; };
188188
/* End PBXFileReference section */
189189

190190
/* Begin PBXFrameworksBuildPhase section */
@@ -410,7 +410,7 @@
410410
043C321927E32295006AE443 /* MainMenu.xib */,
411411
B673FDAC27E8296A00795864 /* PressActionsModifier.swift */,
412412
B658FB3127DA9E0F00EA4DBD /* WorkspaceView.swift */,
413-
FDF7C12127FAEA860039BA76 /* Package.resolved */,
413+
FD6A3D3C2817C13B008BCF11 /* Package.resolved */,
414414
28069DA527F5BD320016BC47 /* DefaultThemes */,
415415
);
416416
path = CodeEdit;
@@ -599,7 +599,7 @@
599599
D7211D4727E06BFE008F2ED7 /* Localizable.strings in Resources */,
600600
28A51001281673530087B0CC /* codeedit-xcode-dark.json in Resources */,
601601
B658FB3427DA9E1000EA4DBD /* Assets.xcassets in Resources */,
602-
FDF7C12227FAEA860039BA76 /* Package.resolved in Resources */,
602+
FD6A3D3D2817C13B008BCF11 /* Package.resolved in Resources */,
603603
043C321A27E32295006AE443 /* MainMenu.xib in Resources */,
604604
);
605605
runOnlyForDeploymentPostprocessing = 0;

CodeEdit/Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,6 @@
4545
</dict>
4646
</array>
4747
<key>GitHash</key>
48-
<string>b65f8ea34ec3259bd783ecb0a4cc49356436e84a</string>
48+
<string>c8d61e8b1c7bae1a749a2f558d537d0c44d6c22e</string>
4949
</dict>
5050
</plist>

CodeEditModules/Modules/About/src/AboutView.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ public struct AboutView: View {
4646
.onHover { _ in
4747
self.hoveringOnCommitHash.toggle()
4848
}
49+
.animation(.easeInOut, value: self.hoveringOnCommitHash)
4950
}.foregroundColor(.secondary)
5051
.font(.system(size: 10, weight: .light))
5152
Spacer().frame(height: 36)

CodeEditModules/Modules/Acknowledgements/src/AcknowledgementsView.swift

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,19 @@ public struct AcknowledgementsView: View {
1616
if let bundlePath = Bundle.main.path(forResource: "Package.resolved", ofType: nil) {
1717
let jsonData = try String(contentsOfFile: bundlePath).data(using: .utf8)
1818
let parsedJSON = try JSONDecoder().decode(RootObject.self, from: jsonData!)
19-
for dependency in parsedJSON.object.pins {
20-
self.acknowledgements.append(
21-
Dependency(name: dependency.package,
22-
repositoryLink: dependency.repositoryURL,
23-
version: dependency.state.version))
19+
for dependency in parsedJSON.object.pins.sorted(by: {$0.package < $1.package}) {
20+
// Filter out Dependencies containing CodeEdit (case insensitive)
21+
if dependency.package.range(of: "[Cc]ode[Ee]dit",
22+
options: .regularExpression, range: nil, locale: nil) == nil {
23+
self.acknowledgements.append(
24+
Dependency(name: dependency.package,
25+
repositoryLink: dependency.repositoryURL,
26+
version: dependency.state.version ?? ""))
27+
}
2428
}
2529
}
2630
} catch {
27-
print("Unable to open Package.resolved")
31+
print(error)
2832
}
2933
}
3034

CodeEditModules/Modules/Acknowledgements/src/ParsePackagesResolved.swift

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
import Foundation
99

10-
// let parsedJSON = try? JSONDecoder().decode(RootObject.self, from: jsonData)
1110
struct Dependency: Decodable {
1211
var name: String
1312
var repositoryLink: String
@@ -19,7 +18,6 @@ struct Dependency: Decodable {
1918

2019
struct RootObject: Codable {
2120
let object: Object
22-
let version: Int
2321
}
2422

2523
// MARK: - Object
@@ -36,5 +34,6 @@ struct Pin: Codable {
3634

3735
// MARK: - State
3836
struct State: Codable {
39-
let revision, version: String
37+
let revision: String
38+
let version: String?
4039
}

Package.resolved

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)