Skip to content

[ENG-2641] File validation error handling #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2021
Merged

[ENG-2641] File validation error handling #1177

merged 1 commit into from
Mar 29, 2021

Conversation

@futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Mar 29, 2021 •
edited by atlassian bot
Loading

Purpose

  • Don't let the file validation status hang in limbo if one of the files fail validation

Summary of Changes

  • wrap the file-loading logic in a try-catch so file validation doesn't break if one of them is an error

Side Effects

QA Notes
@adlius adlius merged commit 6711ce8 into CenterForOpenScience:release/21.1.0 Mar 29, 2021
@fabmiz fabmiz added this to the 21.1.0 milestone Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@futa-ikeda @adlius @brianjgeiger @fabmiz