Skip to content

[ENG-2641] Fix radio button positioning in webkit #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2021
Merged

[ENG-2641] Fix radio button positioning in webkit #1157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cda9d36
fix radio button positioning in webkit
adlius Mar 10, 2021
77975d2
Merge branch 'develop' into webkit-fix
brianjgeiger Mar 10, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/registries/addon/branded/new/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,10 @@
text-transform: uppercase;
}

.RadioButtonAndLabelDiv {
display: inline;
}

.IsChecked {
color: $color-osf-secondary;
background-color: $color-bg-gray-blue-light;
Expand Down
64 changes: 34 additions & 30 deletions lib/registries/addon/branded/new/template.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,36 +28,40 @@
<legend local-class='RadioLegend'>
{{t 'registries.new.step_one_project_heading'}}
</legend>
<input
data-test-has-project-button
local-class='RadioElement RadioInput'
type='radio'
name='HasProject'
value='yes'
onclick={{fn (mut this.isBasedOnProject) true}}
checked={{this.isBasedOnProject}}
>
<label
local-class='RadioElement RadioLabel {{if this.isBasedOnProject 'IsChecked'}}'
for='HasProject'
>
{{t 'registries.new.yes'}}
</label>
<input
data-test-no-project-button
local-class='RadioElement RadioInput'
type='radio'
name='no-project'
value='no'
onclick={{fn (mut this.isBasedOnProject) false}}
checked={{not this.isBasedOnProject}}
>
<label
local-class='RadioElement RadioLabel {{unless this.isBasedOnProject 'IsChecked'}}'
for='NoProject'
>
{{t 'registries.new.no'}}
</label>
<div local-class='RadioButtonAndLabelDiv'>
<input
data-test-has-project-button
local-class='RadioElement RadioInput'
type='radio'
name='HasProject'
value='yes'
onclick={{fn (mut this.isBasedOnProject) true}}
checked={{this.isBasedOnProject}}
>
<label
local-class='RadioElement RadioLabel {{if this.isBasedOnProject 'IsChecked'}}'
for='HasProject'
>
{{t 'registries.new.yes'}}
</label>
</div>
<div local-class='RadioButtonAndLabelDiv'>
<input
data-test-no-project-button
local-class='RadioElement RadioInput'
type='radio'
name='no-project'
value='no'
onclick={{fn (mut this.isBasedOnProject) false}}
checked={{not this.isBasedOnProject}}
>
<label
local-class='RadioElement RadioLabel {{unless this.isBasedOnProject 'IsChecked'}}'
for='NoProject'
>
{{t 'registries.new.no'}}
</label>
</div>
</fieldset>
</label>
{{#if this.isBasedOnProject}}
Expand Down