Skip to content

Commit 8f1e730

Browse files
committed
Merge branch 'release/19.5.1'
2 parents 6cf3306 + 457e95f commit 8f1e730

File tree

46 files changed

+1144
-25
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

46 files changed

+1144
-25
lines changed

CHANGELOG.md

Lines changed: 54 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,58 @@ All notable changes to this project will be documented in this file.
44
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
55
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
66

7+
## [19.5.1] - 2019-06-24
8+
### Added
9+
- Tests:
10+
- Integration:
11+
- `meetings`
12+
- `detail`
13+
- `meeting-detail-header` - add tests for location and dates
14+
- Components:
15+
- `new-home`
16+
- `testimonials` - A section for the testimonials carousel
17+
- `integrations versions A/B` - A list of all supported integrations
18+
- `carousel`
19+
20+
### Changed
21+
- Components:
22+
- `meetings`
23+
- `index`
24+
- `meetings-list` - sort by submission count (descending) by default
25+
- `detail`
26+
- `meeting-submissions-list` - removed download count sorting
27+
- Tests:
28+
- Acceptance:
29+
- `new-home` - Added tests to support integrations section
30+
- Integration:
31+
- `meetings`
32+
- `detail`
33+
- `meeting-submissions-list` - removed checking of download count sorting
34+
- Acceptance:
35+
- `meetings`
36+
- `detail` - add submission with long title
37+
- `index` - add meeting with long name
38+
39+
### Fixed
40+
- Models:
41+
- `meeting-submission` - renamed `created` to `dateCreated` to match API
42+
- Components:
43+
- `meetings`
44+
- `detail`
45+
- `meeting-submissions-list`
46+
- renamed `created` to `dateCreated` to match API
47+
- applied `table-layout: fixed` to force truncating of long submission titles
48+
- `meeting-detail-header` - only attempt to display dates when defined
49+
- `index`
50+
- `meetings-list` - applied `table-layout: fixed` to force truncating of long meeting names
51+
- Tests:
52+
- Integration:
53+
- `meetings`
54+
- `detail`
55+
- `meeting-submissions-list` - renamed `created` to `dateCreated` to match API
56+
- Mirage:
57+
- `meeting-submission` factory - renamed `created` to `dateCreated` to match API
58+
759
## [19.5.0] - 2019-06-07
860
### Added
961
- Models:
@@ -901,7 +953,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
901953
### Added
902954
- Quick Files
903955

904-
[Unreleased]: https://github.com/CenterForOpenScience/ember-osf-web/compare/19.5.0...HEAD
956+
[Unreleased]: https://github.com/CenterForOpenScience/ember-osf-web/compare/19.5.1...HEAD
957+
[19.5.1]: https://github.com/CenterForOpenScience/ember-osf-web/releases/tag/19.5.1
905958
[19.5.0]: https://github.com/CenterForOpenScience/ember-osf-web/releases/tag/19.5.0
906959
[19.4.0]: https://github.com/CenterForOpenScience/ember-osf-web/releases/tag/19.4.0
907960
[19.3.0]: https://github.com/CenterForOpenScience/ember-osf-web/releases/tag/19.3.0

app/locales/en/translations.ts

Lines changed: 51 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -477,6 +477,51 @@ export default {
477477
description: 'Share papers in OSF Preprints or a community-based preprint provider, so others can find and cite your work. Track impact with metrics like downloads and view counts.',
478478
},
479479
},
480+
testimonials: {
481+
heading: 'What others are saying',
482+
see_her_research: 'See her research',
483+
see_his_research: 'See his research',
484+
carousel_heading: 'User testimonials',
485+
slide_1: {
486+
text: 'OSF is a game changer for those wanting to effectively share their research process in the spirit of collaboration.',
487+
alt: 'Patricia Ayala testimonial',
488+
description: {
489+
name: 'Patricia Ayala',
490+
position: 'Research Services Librarian<br>University of Toronto',
491+
},
492+
},
493+
slide_2: {
494+
text: 'OSF is indispensable in helping me create reproducible research pipelines from preregistration through data collection and analysis. Its versatility makes it my one-stop shop for projects. The Dropbox integration effortlessly transforms my existing local workflow to public repository.',
495+
alt: 'Maya testimonial',
496+
description: {
497+
name: 'Maya Mathur',
498+
position: 'Department of Epidemiology<br>Harvard University',
499+
},
500+
},
501+
slide_3: {
502+
text: 'Because SocArXiv is a not-for-profit organization, researchers can be assured that they are sharing their research in an environment where access, inclusivity, and preservation, rather than profit, will remain at the heart of the mission. A great benefit of partnering with OSF is that this application is a free public good.',
503+
alt: 'Philip Cohen testimonial',
504+
description: {
505+
name: 'Philip Cohen',
506+
position: 'SocArXiv papers',
507+
},
508+
},
509+
},
510+
'integrations-section': {
511+
header: 'OSF integrations make your workflow more efficient',
512+
authentication: 'Authentication',
513+
discovery: 'Discovery',
514+
references: 'References',
515+
storage: 'Storage',
516+
incommon: 'Incommon logo',
517+
sso: 'SSO logo',
518+
google_scholar: 'Google Scholar logo',
519+
orcid: 'Orcid logo',
520+
mendeley: 'Mendeley logo',
521+
zotero: 'Zotero logo',
522+
dropbox: 'Dropbox logo',
523+
google_drive: 'Google Drive logo',
524+
},
480525
},
481526
tos_consent: {
482527
paragraph: 'We\'ve updated our <a href="{{link1}}">Terms of Use</a> and <a href="{{link2}}">Privacy Policy</a>. Please read them carefully.',
@@ -1469,6 +1514,12 @@ export default {
14691514
subheading: 'Labs and teams across the globe use OSF to open their projects up to the scientific community.',
14701515
},
14711516
},
1517+
carousel: {
1518+
current_slide: '(Current Slide)',
1519+
previous_slide: 'Previous slide',
1520+
next_slide: 'Next slide',
1521+
go_to_slide: 'Go to slide {{slideIndex}}',
1522+
},
14721523
},
14731524
settings: {
14741525
toggleNav: 'Toggle navigation',

app/meetings/detail/-components/meeting-detail-header/template.hbs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
<h1 data-test-meeting-name>{{this.meeting.name}}</h1>
22

33
<div data-test-meeting-location-and-date local-class='location-and-date-text'>
4-
{{if this.meeting.location (concat this.meeting.location ' | ')}}
5-
{{moment-format this.meeting.startDate 'MMM DD, YYYY'}}
6-
{{if this.meeting.endDate (concat ' - ' (moment-format this.meeting.endDate 'MMM DD, YYYY'))}}
4+
{{if this.meeting.location this.meeting.location}}
5+
{{if (and this.meeting.location (or this.meeting.startDate this.meeting.endDate)) ' | '}}
6+
{{if this.meeting.startDate (moment-format this.meeting.startDate 'MMM DD, YYYY')}}
7+
{{if (or this.meeting.startDate this.meeting.endDate) ' - '}}
8+
{{if this.meeting.endDate (moment-format this.meeting.endDate 'MMM DD, YYYY')}}
79
</div>
810

911
{{#if this.meeting.logoUrl}}

app/meetings/detail/-components/meeting-submissions-list/styles.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
.table {
22
ul {
33
display: table;
4+
table-layout: fixed;
45
width: 100%;
56
border: 1px solid #eee;
67
margin: 0;

app/meetings/detail/-components/meeting-submissions-list/template.hbs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141
</div>
4242
<div data-test-submissions-list-header-download style='width: 15%'>
4343
{{t 'meetings.detail.meeting-submissions-list.downloads'}}
44-
<SortButton @sortBy='download_count' />
4544
</div>
4645
{{/let}}
4746
</list.header>
@@ -59,7 +58,7 @@
5958
{{submission.meetingCategory}}
6059
</div>
6160
<div data-test-submissions-list-item-date>
62-
{{moment-format submission.created 'YYYY-MM-DD hh:mm A'}}
61+
{{moment-format submission.dateCreated 'YYYY-MM-DD hh:mm A'}}
6362
</div>
6463
<div data-test-submissions-list-item-download>
6564
{{#if submission.links.download}}

app/meetings/index/-components/meetings-list/component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ export default class MeetingsList extends Component.extend({
1010
}) {
1111
// Private properties
1212
search?: string;
13-
sort?: string;
13+
sort = '-submissions_count';
1414

1515
@computed('search', 'sort')
1616
get query() {

app/meetings/index/-components/meetings-list/styles.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
.table {
66
ul {
77
display: table;
8+
table-layout: fixed;
89
width: 100%;
910
border: 1px solid #eee;
1011
margin: 0;

app/models/meeting-submission.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export default class MeetingSubmissionModel extends OsfModel {
1515
@attr('string') meetingCategory!: string;
1616
@attr('string') authorName!: string;
1717
@attr('number') downloadCount!: number;
18-
@attr('date') created!: Date;
18+
@attr('date') dateCreated!: Date;
1919
@attr() links!: MeetingSubmissionLinks;
2020

2121
@belongsTo('user', { inverse: null })
Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
import { tagName } from '@ember-decorators/component';
2+
import { alias } from '@ember-decorators/object/computed';
3+
import { service } from '@ember-decorators/service';
4+
import Component from '@ember/component';
5+
import { camelize } from '@ember/string';
6+
import Features from 'ember-feature-flags/services/features';
7+
import config from 'ember-get-config';
8+
9+
import { layout } from 'ember-osf-web/decorators/component';
10+
11+
import styles from './styles';
12+
import template from './template';
13+
14+
const { featureFlagNames: { ABTesting } } = config;
15+
16+
@layout(template, styles)
17+
@tagName('')
18+
export default class IntegrationsSection extends Component {
19+
@service features!: Features;
20+
21+
@alias(`features.${camelize(ABTesting.homePageVersionB)}`)
22+
shouldShowVersionB!: boolean;
23+
}
Lines changed: 122 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,122 @@
1+
$font-color: #263947;
2+
$border: 1px solid #ddd;
3+
4+
.container {
5+
margin-top: 42px;
6+
}
7+
8+
.integrationsHeader {
9+
text-align: center;
10+
padding: 0 20px;
11+
}
12+
13+
.integrationsHeading {
14+
font-size: 32px;
15+
color: $font-color;
16+
font-weight: 600;
17+
}
18+
19+
.flexContainer {
20+
display: flex;
21+
justify-content: center;
22+
padding: 35px 20px 43px;
23+
}
24+
25+
.flexRow {
26+
display: inline-flex;
27+
28+
&:not(:last-of-type) {
29+
border-right: $border;
30+
}
31+
}
32+
33+
.flexColumn {
34+
text-align: center;
35+
width: 255px;
36+
37+
&:not(:last-of-type) {
38+
border-right: $border;
39+
}
40+
}
41+
42+
.logoImg {
43+
height: 32px;
44+
margin: 15px;
45+
46+
&.logoTall {
47+
height: 50px;
48+
}
49+
}
50+
51+
.columnHeader {
52+
font-size: 24px;
53+
font-weight: normal;
54+
color: $font-color;
55+
}
56+
57+
.buttonContainer {
58+
margin-bottom: 53px;
59+
text-align: center;
60+
}
61+
62+
@media (max-width: 1025px) {
63+
.logoImg {
64+
height: 25px;
65+
}
66+
67+
.columnHeader {
68+
font-size: 20px;
69+
}
70+
71+
.flexRow {
72+
width: 50%;
73+
}
74+
}
75+
76+
@media (max-width: 736px) {
77+
.flexColumn {
78+
width: 100%;
79+
}
80+
81+
.flexContainer {
82+
width: 75%;
83+
margin: auto;
84+
flex-wrap: wrap;
85+
}
86+
87+
.flexRow {
88+
width: 100%;
89+
justify-content: center;
90+
91+
&:not(:last-of-type) {
92+
border-right: 0;
93+
border-bottom: $border;
94+
}
95+
}
96+
}
97+
98+
@media (max-width: 613px) {
99+
.flexRow {
100+
display: block;
101+
width: 70%;
102+
}
103+
104+
.flexColumn {
105+
margin: 0 auto;
106+
border-right: 0;
107+
108+
&:not(:last-of-type) {
109+
border-right: 0;
110+
border-bottom: $border;
111+
}
112+
}
113+
114+
.logoImg {
115+
margin: 40px auto;
116+
display: block;
117+
}
118+
119+
.columnHeader {
120+
font-size: 16px;
121+
}
122+
}

0 commit comments

Comments
 (0)