Fix/784 bug (#491)

* fix(citation-format): fixed citation * fix(contributors): fixed deactivated contributor bug * fix(status): fixed registry status * fix(toast): fixed toast message for mobile * fix(dashboard): fixed responsive

Author: nsemets

src/app/features/analytics/components/view-duplicates/view-duplicates.component.html

@@ -56,7 +56,7 @@ <h2 class="flex align-items-center gap-2">
  <span class="font-bold">{{ 'common.labels.contributors' | translate }}:</span>
  @for (contributor of duplicate.contributors; track contributor.id) {
  <div>
- <a [routerLink]="['/user', contributor.id]" class="font-bold"> {{ contributor.fullName }}</a>
+ <a class="font-bold" [routerLink]="['/user', contributor.userId]"> {{ contributor.fullName }}</a>
  <span>{{ $last ? '' : ',' }}</span>
  </div>
  }

src/app/features/home/pages/dashboard/dashboard.component.html

@@ -111,27 +111,31 @@ <h1>{{ 'home.loggedIn.hosting.title' | translate }}</h1>
  data-test-products-collections
  >
  <img
+ class="max-w-full"
  src="assets/images/dashboard/products/osf-collections.png"
  [alt]="'home.loggedIn.dashboard.images.osfCollectionsImageAltText' | translate"
  />
  </a>
 
  <a routerLink="/institutions">
  <img
+ class="max-w-full"
  src="assets/images/dashboard/products/osf-institutions.png"
  [alt]="'home.loggedIn.dashboard.images.osfInstitutionsImageAltText' | translate"
  />
  </a>
 
  <a routerLink="/registries">
  <img
+ class="max-w-full"
  src="assets/images/dashboard/products/osf-registries.png"
  [alt]="'home.loggedIn.dashboard.images.osfRegistriesImageAltTest' | translate"
  />
  </a>
 
  <a routerLink="/preprints">
  <img
+ class="max-w-full"
  src="assets/images/dashboard/products/osf-preprints.png"
  [alt]="'home.loggedIn.dashboard.images.osfPreprintsImageAltTest' | translate"
  />

src/app/features/my-projects/mappers/my-resources.mapper.ts

@@ -1,3 +1,4 @@
+import { ContributorsMapper } from '@osf/shared/mappers';
 import { MyResourcesItem, MyResourcesItemGetResponseJsonApi } from '@osf/shared/models';
 
 export class MyResourcesMapper {
@@ -9,13 +10,7 @@ export class MyResourcesMapper {
  dateCreated: response.attributes.date_created,
  dateModified: response.attributes.date_modified,
  isPublic: response.attributes.public,
- contributors:
- response.embeds?.bibliographic_contributors?.data?.map((contributor) => ({
- familyName: contributor.embeds.users.data?.attributes.family_name,
- fullName: contributor.embeds.users.data?.attributes.full_name,
- givenName: contributor.embeds.users.data?.attributes.given_name,
- middleName: contributor.embeds.users.data?.attributes.middle_name,
- })) ?? [],
+ contributors: ContributorsMapper.getContributorShortInfo(response.embeds?.bibliographic_contributors?.data),
  };
  }
 }

src/app/features/registry/components/registry-statuses/registry-statuses.component.html

@@ -7,20 +7,20 @@
  <p-accordion-content>
  <div class="flex flex-column pt-4 gap-2">
  <h3 class="font-normal">{{ 'registry.overview.statuses.' + registry()?.status + '.short' | translate }}</h3>
- <div class="flex">
- <p>
+ <p>
+ <span>
  {{
  'registry.overview.statuses.' + registry()?.status + '.long'
  | translate: { embargoEndDate: embargoEndDate }
  }}
- </p>
+ </span>
 
  @if (isAccepted()) {
- <a class="font-bold ml-1" [routerLink]="['/', registry()?.associatedProjectId]">
+ <a class="font-bold" [routerLink]="['/', registry()?.associatedProjectId]">
  {{ 'registry.overview.statuses.accepted.project' | translate }}</a
  >.
  }
- </div>
+ </p>
 
  @if (canEdit()) {
  @if (canWithdraw()) {

src/app/shared/components/my-projects-table/my-projects-table.component.spec.ts

@@ -34,10 +34,9 @@ describe('MyProjectsTableComponent', () => {
  dateModified: '2024-01-01T10:00:00Z',
  contributors: [
  {
- familyName: 'John Doe',
+ id: '1',
+ userId: 'user1',
  fullName: 'Jane Smith',
- middleName: 'Jane Smith',
- givenName: 'Jane Smith',
  },
  ],
  type: '',

src/app/shared/components/registration-card/registration-card.component.html

@@ -39,7 +39,7 @@ <h2 class="align-self-center word-break-word">
  <strong>{{ 'project.overview.metadata.contributors' | translate }}:</strong>
  <span class="contributors">
  @for (contributor of registrationData().contributors; track contributor) {
- <a class="font-bold" [routerLink]="['/user', contributor.id]">{{ contributor.fullName }}</a>
+ <a class="font-bold" [routerLink]="['/user', contributor.userId]">{{ contributor.fullName }}</a>
  @if (!$last) {
  <span>, </span>
  }

src/app/shared/components/toast/toast.component.html

@@ -1,4 +1,10 @@
-<p-toast class="toast-container" position="top-right" [preventOpenDuplicates]="true" key="osf">
+<p-toast
+ class="toast-container"
+ position="top-right"
+ [preventOpenDuplicates]="true"
+ key="osf"
+ [breakpoints]="{ '576px': { width: '80%' } }"
+>
  <ng-template let-message pTemplate="message">
  <div class="font-medium w-full">{{ message.summary | translate: message.data?.translationParams }}</div>
  </ng-template>

src/app/shared/mappers/contributors/contributors.mapper.ts

@@ -11,8 +11,14 @@ import {
 } from '@osf/shared/models';
 
 export class ContributorsMapper {
- static fromResponse(response: ContributorDataJsonApi[]): ContributorModel[] {
- return response.map((contributor) => this.fromContributorResponse(contributor));
+ static fromResponse(response: ContributorDataJsonApi[] | undefined): ContributorModel[] {
+ if (!response) {
+ return [];
+ }
+
+ return response
+ .filter((contributor) => !contributor?.embeds?.users?.errors)
+ .map((contributor) => this.fromContributorResponse(contributor));
  }
 
  static fromContributorResponse(response: ContributorDataJsonApi): ContributorModel {
@@ -33,7 +39,7 @@ export class ContributorsMapper {
  };
  }
 
- static getContributorShortInfo(response: ContributorDataJsonApi[]): ContributorShortInfoModel[] {
+ static getContributorShortInfo(response: ContributorDataJsonApi[] | undefined): ContributorShortInfoModel[] {
  const contributors = this.fromResponse(response);
 
  return contributors.map((contributor) => ({

src/app/shared/mappers/duplicates.mapper.ts

@@ -1,6 +1,8 @@
 import { ResponseJsonApi } from '@shared/models';
 
-import { DuplicateJsonApi, DuplicatesWithTotal } from 'src/app/shared/models/duplicates';
+import { DuplicateJsonApi, DuplicatesWithTotal } from '../models/duplicates';
+
+import { ContributorsMapper } from './contributors';
 
 export class DuplicatesMapper {
  static fromDuplicatesJsonApiResponse(response: ResponseJsonApi<DuplicateJsonApi[]>): DuplicatesWithTotal {
@@ -14,14 +16,7 @@ export class DuplicatesMapper {
  dateModified: duplicate.attributes.date_modified,
  public: duplicate.attributes.public,
  currentUserPermissions: duplicate.attributes.current_user_permissions,
- contributors: duplicate.embeds.bibliographic_contributors.data.map((contributor) => ({
- familyName: contributor.embeds.users.data.attributes.family_name,
- fullName: contributor.embeds.users.data.attributes.full_name,
- givenName: contributor.embeds.users.data.attributes.given_name,
- middleName: contributor.embeds.users.data.attributes.middle_name,
- id: contributor.embeds.users.data.id,
- type: contributor.embeds.users.data.type,
- })),
+ contributors: ContributorsMapper.getContributorShortInfo(duplicate.embeds.bibliographic_contributors.data),
  })),
  totalCount: response.meta.total,
  };

src/app/shared/mappers/registration/registration.mapper.ts

@@ -9,6 +9,8 @@ import {
  SchemaResponseDataJsonApi,
 } from '@osf/shared/models';
 
+import { ContributorsMapper } from '../contributors';
+
 import { MapRegistryStatus } from './map-registry-status.mapper';
 
 export class RegistrationMapper {
@@ -66,11 +68,7 @@ export class RegistrationMapper {
  registrationTemplate: registration.embeds?.registration_schema?.data?.attributes?.name || '',
  registry: registration.embeds?.provider?.data?.attributes?.name || '',
  public: registration.attributes.public,
- contributors:
- registration.embeds?.bibliographic_contributors?.data.map((contributor) => ({
- id: contributor.id,
- fullName: contributor.embeds?.users?.data.attributes.full_name,
- })) || [],
+ contributors: ContributorsMapper.getContributorShortInfo(registration.embeds?.bibliographic_contributors?.data),
  currentUserPermissions: registration.attributes.current_user_permissions,
  };
  }
@@ -93,11 +91,7 @@ export class RegistrationMapper {
  hasMaterials: registration.attributes.has_materials,
  hasPapers: registration.attributes.has_papers,
  hasSupplements: registration.attributes.has_supplements,
- contributors:
- registration.embeds?.bibliographic_contributors?.data.map((contributor) => ({
- id: contributor.embeds.users.data.id,
- fullName: contributor.embeds.users.data.attributes.full_name,
- })) || [],
+ contributors: ContributorsMapper.getContributorShortInfo(registration.embeds?.bibliographic_contributors?.data),
  rootParentId: registration.relationships.root?.data?.id,
  currentUserPermissions: registration.attributes.current_user_permissions,
  };