[ENG-9053] feat(banner): fix scheduled banner placement (#535)

* feat(banner): fix scheduled banner placement * feat(banner): remove component import from osf-banner test

Author: adlius

src/app/core/components/osf-banners/osf-banner.component.html

@@ -1,4 +1,3 @@
-<osf-scheduled-banner></osf-scheduled-banner>
 <osf-maintenance-banner></osf-maintenance-banner>
 <osf-cookie-consent-banner></osf-cookie-consent-banner>
 <osf-tos-consent-banner></osf-tos-consent-banner>

src/app/core/components/osf-banners/osf-banner.component.spec.ts

@@ -4,7 +4,6 @@ import { ComponentFixture, TestBed } from '@angular/core/testing';
 import { NoopAnimationsModule } from '@angular/platform-browser/animations';
 
 import { CookieConsentBannerComponent } from './cookie-consent-banner/cookie-consent-banner.component';
-import { ScheduledBannerComponent } from './scheduled-banner/scheduled-banner.component';
 import { TosConsentBannerComponent } from './tos-consent-banner/tos-consent-banner.component';
 import { OSFBannerComponent } from './osf-banner.component';
 
@@ -22,7 +21,6 @@ describe('Component: OSF Banner', () => {
  OSFBannerComponent,
  NoopAnimationsModule,
  MockComponentWithSignal('osf-maintenance-banner'),
- MockComponent(ScheduledBannerComponent),
  MockComponent(CookieConsentBannerComponent),
  MockComponent(TosConsentBannerComponent),
  ],

src/app/core/components/osf-banners/osf-banner.component.ts

@@ -2,7 +2,6 @@ import { ChangeDetectionStrategy, Component } from '@angular/core';
 
 import { CookieConsentBannerComponent } from './cookie-consent-banner/cookie-consent-banner.component';
 import { MaintenanceBannerComponent } from './maintenance-banner/maintenance-banner.component';
-import { ScheduledBannerComponent } from './scheduled-banner/scheduled-banner.component';
 import { TosConsentBannerComponent } from './tos-consent-banner/tos-consent-banner.component';
 
 /**
@@ -22,12 +21,7 @@ import { TosConsentBannerComponent } from './tos-consent-banner/tos-consent-bann
  */
 @Component({
  selector: 'osf-banner-component',
- imports: [
- MaintenanceBannerComponent,
- ScheduledBannerComponent,
- CookieConsentBannerComponent,
- TosConsentBannerComponent,
- ],
+ imports: [MaintenanceBannerComponent, CookieConsentBannerComponent, TosConsentBannerComponent],
  templateUrl: './osf-banner.component.html',
  changeDetection: ChangeDetectionStrategy.OnPush,
 })

src/app/features/home/pages/dashboard/dashboard.component.html

@@ -10,6 +10,7 @@
  [buttonLabel]="'home.loggedIn.dashboard.createProject' | translate"
  (buttonClick)="createProject()"
  />
+ <osf-scheduled-banner />
  <div>
  <div class="quick-search-container py-4 px-3 md:px-4">
  <p class="text-center mb-4 xl:mb-6">

src/app/features/home/pages/dashboard/dashboard.component.ts

@@ -13,6 +13,7 @@ import { takeUntilDestroyed, toSignal } from '@angular/core/rxjs-interop';
 import { FormControl } from '@angular/forms';
 import { ActivatedRoute, Router, RouterLink } from '@angular/router';
 
+import { ScheduledBannerComponent } from '@core/components/osf-banners/scheduled-banner/scheduled-banner.component';
 import { CreateProjectDialogComponent } from '@osf/features/my-projects/components';
 import {
  IconComponent,
@@ -37,6 +38,7 @@ import { ClearMyResources, GetMyProjects, MyResourcesSelectors } from '@osf/shar
  IconComponent,
  TranslatePipe,
  LoadingSpinnerComponent,
+ ScheduledBannerComponent,
  ],
  templateUrl: './dashboard.component.html',
  styleUrl: './dashboard.component.scss',

src/app/features/institutions/pages/institutions-list/institutions-list.component.html

@@ -5,6 +5,7 @@
  [title]="'institutions.title' | translate"
  [icon]="'custom-icon-institutions-dark'"
  />
+ <osf-scheduled-banner />
  <div class="flex-column flex flex-1 w-full bg-white p-5">
  <osf-search-input [control]="searchControl" [placeholder]="'institutions.searchInstitutions' | translate" />
 

src/app/features/institutions/pages/institutions-list/institutions-list.component.ts

@@ -10,6 +10,7 @@ import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
 import { FormControl } from '@angular/forms';
 import { ActivatedRoute, Router, RouterLink } from '@angular/router';
 
+import { ScheduledBannerComponent } from '@core/components/osf-banners/scheduled-banner/scheduled-banner.component';
 import { LoadingSpinnerComponent, SearchInputComponent, SubHeaderComponent } from '@osf/shared/components';
 import { FetchInstitutions, InstitutionsSelectors } from '@osf/shared/stores';
 
@@ -21,6 +22,7 @@ import { FetchInstitutions, InstitutionsSelectors } from '@osf/shared/stores';
  SearchInputComponent,
  NgOptimizedImage,
  LoadingSpinnerComponent,
+ ScheduledBannerComponent,
  RouterLink,
  ],
  templateUrl: './institutions-list.component.html',

src/app/features/registries/pages/registries-landing/registries-landing.component.html

@@ -8,6 +8,7 @@
  [buttonLabel]="'registries.addRegistration' | translate"
  (buttonClick)="goToCreateRegistration()"
  />
+ <osf-scheduled-banner />
  <osf-search-input
  class="w-full py-4 px-4"
  [control]="searchControl"

src/app/features/registries/pages/registries-landing/registries-landing.component.ts

@@ -8,6 +8,7 @@ import { ChangeDetectionStrategy, Component, inject, OnDestroy, OnInit } from '@
 import { FormControl } from '@angular/forms';
 import { Router } from '@angular/router';
 
+import { ScheduledBannerComponent } from '@core/components/osf-banners/scheduled-banner/scheduled-banner.component';
 import { ENVIRONMENT } from '@core/provider/environment.provider';
 import { ClearCurrentProvider } from '@core/store/provider';
 import {
@@ -36,6 +37,7 @@ import { GetRegistries, RegistriesSelectors } from '../../store';
  ResourceCardComponent,
  LoadingSpinnerComponent,
  SubHeaderComponent,
+ ScheduledBannerComponent,
  ],
  templateUrl: './registries-landing.component.html',
  styleUrl: './registries-landing.component.scss',