Update develop from main (#322)

* Fix/improvements (#319) * fix(meetings): fixed meetings small issues * fix(tooltips): added tooltips * fix(table): updated sorting * fix(settings): fixed update project * fix(bookmarks): updated bookmarks * fix(my-registrations): fixed my registrations * fix(developer-apps): fixed developer apps * fix(settings): updated tokens and notifications * fix(translation): removed dot * fix(info-icon): updated info icon translate * fix(profile-settings): fixed profile settings * fix(test): updated tests * fix(settings): updated settings * fix(user-emails): updated adding emails to user account * fix(tests): updated tests * fix(clean-up): clean up * fix(models): updated models * fix(models): updated region and license models * fix(styles): moved styles from assets * fix(test): fixed institution loading and test for view only link * fix(analytics): added check if is public * fix(analytics): updated analytics feature * fix(analytics): show message when data loaded * fix(view-only-links): updated view only links * fix(view only links): added shared components * fix(tests): fixed tests * fix(unit-tests): updated jest config * fix(view-only-links): update view only links for components * fix(create-view-link): added logic for uncheck --------- Co-authored-by: Nazar Semets <nazar690@gmail.com> * Test/387 settings page tokens (#318) * test(tokens): added new tests * test(tokens): added new unit tests * test(tokens): fixed tests and jest.config * test(tokens): fixed pr comments * Fix - Search (#286) * feat(search): added generic search component * feat(search): improved search for institutions * feat(search): remove unused files * feat(search): fixed some issues * fix(search): removed comments * fix(profile): renamed it to profile * fix(updates): updates * fix(branding): Minor fixed regarding provider hero for preprints and registry * refactor(search-results-container): Encapsulated some logic, reduced duplication * refactor(search-results-container): Encapsulated tabs logic * refactor(search): Refactored partly search section for preprints and profile * refactor(search): Refactored search logic for global, institutions page, registrations page search * refactor(search): Refactored search logic for global, institutions page, registrations page search * refactor(search): Refactored search logic for profile * feat(profile): Implemented my-profile and user/:id pages * refactor(preprint-provider-discover): Removed search section that uses old approach * refactor(search): Create shared component that encapsulates search logic and reused across the app * refactor(shared-search): Extracted state model. Reduced duplications. Fixed IndexValueSearch filters * refactor(search): Using ResourceType instead of ResourceTab. Fixed params for index-value-search * refactor(search-models): Cleaned up models - renamed files, moved models to appropriate locations * refactor(index-card-search): Refactored models * fix(resource-card): Fixed resource-card component * fix(resource-card-secondary-metadata): Fixed resource-card component * fix(search): Fixed PR comments and conflicts after merge * refactor(search): Renamed OsfSearch- to GlobalSearch- * fix(unit-tests): fixed unit tests --------- Co-authored-by: volodyayakubovskyy <vyakubovskyy477@gmail.com> Co-authored-by: nsemets <nsemets@exoft.net> * Fix/557 missing tooltip (#320) * fix(tooltip): added tooltip to next button * fix(emails): fixed emails bug * chore(test-env): added test env (#321) * Chore/test docs added more docs and updated docs in the ever expanding evolution. (#309) * chore(testing-docs): incremental update to the testing docs * chore(diagram): updated the ngx application diagram * chore(indexes): added indexes to all files * docs(updates): added new docs and explanations * chore(pr-updates): updated the files based on pr feedback --------- Co-authored-by: nsemets <nsemets@exoft.net> Co-authored-by: Nazar Semets <nazar690@gmail.com> Co-authored-by: dinlvkdn <104976612+dinlvkdn@users.noreply.github.com> Co-authored-by: rrromchIk <90086332+rrromchIk@users.noreply.github.com> Co-authored-by: volodyayakubovskyy <vyakubovskyy477@gmail.com>

Author: 6 people

.github/workflows/review.yml

@@ -3,9 +3,7 @@ name: Require at least one approval
 
 on:
  pull_request:
- types: [opened, reopened, ready_for_review, synchronize]
- pull_request_review:
- types: [submitted, edited, dismissed]
+ types: [opened, reopened, ready_for_review, synchronize, edited]
 
 jobs:
  check-approval:

README.md

@@ -25,6 +25,7 @@ take up to 60 seconds once the docker build finishes.
 - [Docker Commands](docs/docker.md).
 - [ESLint Strategy](docs/eslint.md).
 - [Git Conventions](docs/git-convention.md).
+- [i18n](docs/i18n.md).
 - [NGXS Conventions](docs/ngxs.md).
 - [Testing Strategy](docs/testing.md).
 

angular.json

@@ -90,6 +90,17 @@
  }
  ]
  },
+ "test-osf": {
+ "optimization": false,
+ "extractLicenses": false,
+ "sourceMap": true,
+ "fileReplacements": [
+ {
+ "replace": "src/environments/environment.ts",
+ "with": "src/environments/environment.test-osf.ts"
+ }
+ ]
+ },
  "development": {
  "optimization": false,
  "extractLicenses": false,
@@ -117,6 +128,10 @@
  "local": {
  "buildTarget": "osf:build:local",
  "hmr": false
+ },
+ "test-osf": {
+ "buildTarget": "osf:build:test-osf",
+ "hmr": false
  }
  },
  "defaultConfiguration": "development"

commitlint.config.cjs

@@ -5,15 +5,16 @@ module.exports = {
  2,
  'always',
  [
+ 'chore', // Build process, CI/CD, dependencies
+ 'docs', // Documentation update
  'feat', // New feature
  'fix', // Bug fix
- 'docs', // Documentation update
- 'style', // Code style (formatting, missing semicolons, etc.)
- 'refactor', // Code refactoring (no feature changes)
+ 'lang', // All updates related to i18n changes
  'perf', // Performance improvements
- 'test', // Adding tests
- 'chore', // Build process, CI/CD, dependencies
+ 'refactor', // Code refactoring (no feature changes)
  'revert', // Reverting changes
+ 'style', // Code style (formatting, missing semicolons, etc.)
+ 'test', // Adding tests
  ],
  ],
  'scope-empty': [2, 'never'], // Scope must always be present

docs/admin.knowledge-base.md

@@ -1,7 +1,18 @@
 # Admin Knowledge Base
 
+## Index
+
+- [Overview](#overview)
+- [All things GitHub](#all-things-github)
+
+---
+
+## Overview
+
 Information on updates that require admin permissions
 
+---
+
 ## All things GitHub
 
 ### GitHub pipeline
@@ -16,6 +27,8 @@ The `.github` folder contains the following:
  .github/workflows
 4. The GitHub PR templates
  .github/pull_request_template.md
+5. The backup json for the settings/rules
+ .github/rules
 
 ### Local pipeline
 

docs/assets/osf-ngxs-diagram.png

@@ -1,5 +1,7 @@
 ## 📝 Enabling the Shared Commit Template
 
+## Overview
+
 This project includes a Git commit message template stored at:
 
 ```

docs/commit.template.md

@@ -1,5 +1,20 @@
 # Angular Documentation with Compodoc
 
+## Index
+
+- [Overview](#overview)
+- [How to Generate Documentation](#how-to-generate-documentation)
+- [Documentation Coverage Requirements](#documentation-coverage-requirements)
+- [Pre-commit Enforcement via Husky](#pre-commit-enforcement-via-husky)
+- [CI/CD Enforcement](#cicd-enforcement)
+- [Tips for Passing Coverage](#tips-for-passing-coverage)
+- [Output Directory](#output-directory)
+- [Need Help?](#need-help)
+
+---
+
+## Overview
+
 This project uses [Compodoc](https://compodoc.app/) to generate and enforce documentation for all Angular code. Documentation is mandatory and must meet a **100% coverage threshold** to ensure consistent API clarity across the codebase.
 
 ---

docs/compodoc.md

@@ -1,5 +1,15 @@
 # Docker
 
+## Index
+
+- [Overview](#overview)
+- [Docker Commands](#docker-commands)
+- [Troubleshooting](#troubleshooting)
+
+---
+
+## Overview
+
 The OSF angular project uses a docker image to simplify the developer process.
 
 ### Volumes
@@ -33,6 +43,8 @@ If you don’t see the site, ensure the start script includes:
 "start": "ng serve --host 0.0.0.0 --port 4200 --poll 2000"
 ```
 
+---
+
 ## Docker Commands
 
 ### build + run in background (build is only required for the initial install or npm updates)
@@ -105,6 +117,8 @@ docker rmi <image_name>:<tag>
 docker rmi -f <IMAGE_ID>
 ```
 
+---
+
 ## Troubleshooting
 
 If the application does not open in your browser at [http://localhost:4200](http://localhost:4200), follow these steps in order:

docs/docker.md

@@ -1,5 +1,13 @@
 # Linting Strategy – OSF Angular
 
+## Index
+
+- [Overview](#overview)
+- [Linting Commands](#linting-commands)
+- [ESLint Config Structure](#eslint-config-structure)
+- [Pre-Commit Hook](#pre-commit-hook)
+- [Summary](#summary)
+
 ---
 
 ## Overview
@@ -12,6 +20,9 @@ This project uses a **unified, modern ESLint flat config** approach to enforce c
 
 It also integrates into the **Git workflow** via `pre-commit` hooks to ensure clean, compliant code before every commit.
 
+**IMPORTANT**
+The OSF application must meet full accessibility (a11y) compliance to ensure equitable access for users of all abilities, in alignment with our commitment to inclusivity and funding obligations.
+
 ---
 
 ## Linting Commands