Skip to content

Commit 96d8fdf

Browse files
committed
Update with latest JDK and tomcat
1 parent e1352ce commit 96d8fdf

File tree

3 files changed

+26
-40
lines changed

3 files changed

+26
-40
lines changed

.github/workflows/mavenpublish.yml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@ name: Maven Package
33

44
on:
55
push:
6-
schedule:
7-
- cron: '0 0 * * *'
86

97
jobs:
108
build:
@@ -26,6 +24,8 @@ jobs:
2624
repository: CRaC/utils
2725
path: utils
2826

27+
- run: make -C utils
28+
2929
- name: Set up JDK 1.8
3030
uses: actions/setup-java@v1
3131
with:
@@ -37,9 +37,7 @@ jobs:
3737
restore-keys: |
3838
${{ runner.os }}-maven-
3939
40-
- run: mvn -s settings.xml -B package
41-
env:
42-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
40+
- run: mvn -B package
4341

4442
- name: Test on Vanila JDK
4543
run: |
@@ -52,19 +50,21 @@ jobs:
5250
5351
- name: Download JDK
5452
run: |
55-
utils/download-jdk.sh
56-
sudo tar -axf jdk14-crac.tar.gz
53+
archive=$(utils/download-jdk.sh)
54+
sudo tar -axf $archive
55+
echo JDK=${archive%%.tar.gz} >> $GITHUB_ENV
5756
5857
- name: Prepare warm checkpoint
5958
run: |
6059
P=$(utils/start-bg.sh \
6160
-s "Started Application" \
6261
-e exitcode \
63-
jdk14-crac/bin/java \
62+
${{ env.JDK }}/bin/java \
6463
-XX:CRaCCheckpointTo=cr \
6564
-XX:+UnlockDiagnosticVMOptions \
6665
-XX:+CRTraceStartupTime \
6766
-Djdk.crac.trace-startup-time=true \
67+
--add-opens java.base/java.lang=ALL-UNNAMED \
6868
-jar target/spring-boot-0.0.1-SNAPSHOT.jar)
6969
7070
# warmup the service
@@ -76,12 +76,12 @@ jobs:
7676
run: |
7777
P=$(utils/start-bg.sh \
7878
-s "restore-finish" \
79-
jdk14-crac/bin/java -XX:CRaCRestoreFrom=cr)
79+
${{ env.JDK }}/bin/java -XX:CRaCRestoreFrom=cr)
8080
curl localhost:8080 | grep "Greetings from Spring Boot!"
8181
utils/bench.sh http://localhost:8080
8282
kill $P
8383
8484
- name: Test C/RaC startup time
8585
run:
86-
timeout 3 bash -c "jdk14-crac/lib/javatime ; jdk14-crac/bin/java -XX:CRaCRestoreFrom=cr"
86+
timeout 3 bash -c "utils/lib/javatime ; ${{ env.JDK }}/bin/java -XX:CRaCRestoreFrom=cr"
8787
| utils/sel.awk -v from=prestart -v to=restore-finish

pom.xml

Lines changed: 16 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -14,27 +14,26 @@
1414
<name>spring-boot</name>
1515
<description>Demo project for Spring Boot</description>
1616

17-
<repositories>
18-
<repository>
19-
<id>github</id>
20-
<url>https://maven.pkg.github.com/crac/tomcat</url>
21-
</repository>
22-
<repository>
23-
<id>github2</id>
24-
<url>https://maven.pkg.github.com/crac/org.crac</url>
25-
</repository>
26-
</repositories>
27-
28-
2917
<properties>
3018
<java.version>1.8</java.version>
31-
<tomcat.version>999-SNAPSHOT</tomcat.version>
19+
<tomcat.version>8.5.75</tomcat.version>
3220
</properties>
3321

3422
<dependencies>
23+
<dependency>
24+
<groupId>io.github.crac.org.apache.tomcat.embed</groupId>
25+
<artifactId>tomcat-embed-core</artifactId>
26+
<version>8.5.75</version>
27+
</dependency>
3528
<dependency>
3629
<groupId>org.springframework.boot</groupId>
3730
<artifactId>spring-boot-starter-web</artifactId>
31+
<exclusions>
32+
<exclusion>
33+
<groupId>org.apache.tomcat.embed</groupId>
34+
<artifactId>tomcat-embed-core</artifactId>
35+
</exclusion>
36+
</exclusions>
3837
</dependency>
3938

4039
<dependency>
@@ -46,6 +45,10 @@
4645
<groupId>org.junit.vintage</groupId>
4746
<artifactId>junit-vintage-engine</artifactId>
4847
</exclusion>
48+
<exclusion>
49+
<groupId>org.apache.tomcat</groupId>
50+
<artifactId>tomcat-embed-core</artifactId>
51+
</exclusion>
4952
</exclusions>
5053
</dependency>
5154
</dependencies>

settings.xml

Lines changed: 0 additions & 17 deletions
This file was deleted.

0 commit comments

Comments
 (0)