Use latest prompt_toolkit #194
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Love the 3.10 migration work! Forced the update to prompt_toolkit=3.0.32 on my machine and it introduces an import error. More work would need to resolve that: |
bkus added a commit to HamWAN/packer-routeros that referenced this pull request Jan 21, 2023
There's a fix for the PyInquirer breakage: CITGuru/PyInquirer#194 But PyInquirer doesn't have a maintainer anymore: CITGuru/PyInquirer#159 The sudo bundle update is because some gems have native extensions, and those don't get installed or recognized properly by the subsequent rake build.
| I know the PyPi is not up to date and forces users to install older prompt-toolkit. The workaround for me that worked is to install from the latest commit. It did pull the prompt-toolkit 3.x.xx and didn't raise any errors when loading it. The change I made in the code moving from PyPi install is change the import of prompt from PyInquirer, |
| And what about to do: try: from collections.abc import Mapping except ImportError: from collections import Mappingto keep that backwards compatible? |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This resolves an import error in the collections library when using python 3.10 or higher.