Make CodeController.language and CodeController.theme mutable (#41, #42) #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
alexeyinkin commented Jun 16, 2022
| this.onChange, | ||
| }) : super(text: text) { | ||
| // PatternMap | ||
| if (language != null && theme == null) throw Exception("A theme must be provided for language parsing"); |
Collaborator Author
There was a problem hiding this comment.
If we allow to change language and theme, then I suggest we allow language without theme. If they both present, then we will format the code. If either one is not present, then not.
Otherwise there will be too much checks, and a nasty method like setThemeAndLanguage to set both in one call.
Collaborator Author
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #41, Fixes #42