[Storage] API View Feedback For STG84 GA (#25085)

Author: vincenttran-msft

sdk/storage/azure-storage-blob/CHANGELOG.md

@@ -1,8 +1,6 @@
 # Release History
 
-## 12.13.0 (Unreleased)
-
-### Features Added
+## 12.13.0 (2022-07-07)
 
 ### Bugs Fixed
 - Stable release of features from 12.13.0b1.

sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client.py

@@ -185,7 +185,7 @@ def __init__(
  super(BlobClient, self).__init__(parsed_url, service='blob', credential=credential, **kwargs)
  self._client = AzureBlobStorage(self.url, base_url=self.url, pipeline=self._pipeline)
  self._client._config.version = get_api_version(kwargs) # pylint: disable=protected-access
- self.configure_encryption(kwargs)
+ self._configure_encryption(kwargs)
 
  def _format_url(self, hostname):
  container_name = self.container_name

sdk/storage/azure-storage-blob/azure/storage/blob/_blob_service_client.py

@@ -136,7 +136,7 @@ def __init__(
  super(BlobServiceClient, self).__init__(parsed_url, service='blob', credential=credential, **kwargs)
  self._client = AzureBlobStorage(self.url, base_url=self.url, pipeline=self._pipeline)
  self._client._config.version = get_api_version(kwargs) # pylint: disable=protected-access
- self.configure_encryption(kwargs)
+ self._configure_encryption(kwargs)
 
  def _format_url(self, hostname):
  """Format the endpoint URL according to the current location

sdk/storage/azure-storage-blob/azure/storage/blob/_container_client.py

@@ -155,7 +155,7 @@ def __init__(
  super(ContainerClient, self).__init__(parsed_url, service='blob', credential=credential, **kwargs)
  self._client = AzureBlobStorage(self.url, base_url=self.url, pipeline=self._pipeline)
  self._client._config.version = get_api_version(kwargs) # pylint: disable=protected-access
- self.configure_encryption(kwargs)
+ self._configure_encryption(kwargs)
 
  def _format_url(self, hostname):
  container_name = self.container_name

sdk/storage/azure-storage-blob/azure/storage/blob/_encryption.py

@@ -55,7 +55,7 @@ def _validate_key_encryption_key_wrap(kek):
 
 
 class StorageEncryptionMixin(object):
- def configure_encryption(self, kwargs):
+ def _configure_encryption(self, kwargs):
  self.require_encryption = kwargs.get("require_encryption", False)
  self.encryption_version = kwargs.get("encryption_version", "1.0")
  self.key_encryption_key = kwargs.get("key_encryption_key")

sdk/storage/azure-storage-blob/azure/storage/blob/aio/_blob_client_async.py

@@ -131,7 +131,7 @@ def __init__(
  **kwargs)
  self._client = AzureBlobStorage(self.url, base_url=self.url, pipeline=self._pipeline)
  self._client._config.version = get_api_version(kwargs) # pylint: disable=protected-access
- self.configure_encryption(kwargs)
+ self._configure_encryption(kwargs)
 
  @distributed_trace_async
  async def get_account_information(self, **kwargs): # type: ignore

sdk/storage/azure-storage-blob/azure/storage/blob/aio/_blob_service_client_async.py

@@ -125,7 +125,7 @@ def __init__(
  **kwargs)
  self._client = AzureBlobStorage(self.url, base_url=self.url, pipeline=self._pipeline)
  self._client._config.version = get_api_version(kwargs) # pylint: disable=protected-access
- self.configure_encryption(kwargs)
+ self._configure_encryption(kwargs)
 
  @distributed_trace_async
  async def get_user_delegation_key(self, key_start_time, # type: datetime

sdk/storage/azure-storage-blob/azure/storage/blob/aio/_container_client_async.py

@@ -121,7 +121,7 @@ def __init__(
  **kwargs)
  self._client = AzureBlobStorage(self.url, base_url=self.url, pipeline=self._pipeline)
  self._client._config.version = get_api_version(kwargs) # pylint: disable=protected-access
- self.configure_encryption(kwargs)
+ self._configure_encryption(kwargs)
 
  @distributed_trace_async
  async def create_container(self, metadata=None, public_access=None, **kwargs):

sdk/storage/azure-storage-file-datalake/CHANGELOG.md

@@ -1,9 +1,10 @@
 # Release History
 
-## 12.8.0 (Unreleased)
+## 12.8.0 (2022-07-07)
 
 ### Features Added
 - Stable release of features from 12.8.0b1.
+- Removed support for `expiry_options` from file `create` APIs. With this change, `expires_on` now covers all functionality `expiry_options` offered.
 
 ## 12.8.0b1 (2022-06-15)
 

sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_data_lake_directory_client.py

@@ -194,7 +194,7 @@ def create_directory(self, metadata=None, # type: Optional[Dict[str, str]]
  return self._create('directory', metadata=metadata, **kwargs)
 
  def delete_directory(self, **kwargs):
- # type: (...) -> Dict[str, Union[str, datetime]]
+ # type: (...) -> None
  """
  Marks the specified directory for deletion.
 
@@ -221,8 +221,7 @@ def delete_directory(self, **kwargs):
  The match condition to use upon the etag.
  :keyword int timeout:
  The timeout parameter is expressed in seconds.
- :return: A dictionary of response headers.
- :rtype: Dict[str, Union[str, datetime]]
+ :return: None
 
  .. admonition:: Example: