Skip to content

Commit 8a9c0d0

Browse files
authored
Fix live tests for aztables (#19922)
The SAS tests used hard-coded start and expiry times which are no longer valid and cause false failures.
1 parent 3a39031 commit 8a9c0d0

File tree

1 file changed

+12
-8
lines changed

1 file changed

+12
-8
lines changed

sdk/data/aztables/shared_access_signature_test.go

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,9 @@ func TestSASServiceClient(t *testing.T) {
5050
Update: true,
5151
Delete: true,
5252
}
53-
start := time.Date(2021, time.August, 4, 1, 1, 0, 0, time.UTC)
54-
expiry := time.Date(2022, time.August, 4, 1, 1, 0, 0, time.UTC)
53+
54+
start := time.Now().Add(-1 * time.Hour).UTC()
55+
expiry := time.Now().Add(24 * time.Hour).UTC()
5556

5657
sasUrl, err := serviceClient.GetAccountSASURL(resources, permissions, start, expiry)
5758
require.NoError(t, err)
@@ -95,8 +96,9 @@ func TestSASClient(t *testing.T) {
9596
Read: true,
9697
Add: true,
9798
}
98-
start := time.Date(2021, time.August, 4, 1, 1, 0, 0, time.UTC)
99-
expiry := time.Date(2022, time.August, 4, 1, 1, 0, 0, time.UTC)
99+
100+
start := time.Now().Add(-1 * time.Hour).UTC()
101+
expiry := time.Now().Add(24 * time.Hour).UTC()
100102

101103
c := serviceClient.NewClient(tableName)
102104
sasUrl, err := c.GetTableSASURL(permissions, start, expiry)
@@ -149,8 +151,9 @@ func TestSASClientReadOnly(t *testing.T) {
149151
permissions := SASPermissions{
150152
Read: true,
151153
}
152-
start := time.Date(2021, time.August, 4, 1, 1, 0, 0, time.UTC)
153-
expiry := time.Date(2022, time.August, 4, 1, 1, 0, 0, time.UTC)
154+
155+
start := time.Now().Add(-1 * time.Hour).UTC()
156+
expiry := time.Now().Add(24 * time.Hour).UTC()
154157

155158
c := serviceClient.NewClient(tableName)
156159
sasUrl, err := c.GetTableSASURL(permissions, start, expiry)
@@ -218,8 +221,9 @@ func TestSASCosmosClientReadOnly(t *testing.T) {
218221
permissions := SASPermissions{
219222
Read: true,
220223
}
221-
start := time.Date(2021, time.August, 4, 1, 1, 0, 0, time.UTC)
222-
expiry := time.Date(2022, time.August, 4, 1, 1, 0, 0, time.UTC)
224+
225+
start := time.Now().Add(-1 * time.Hour).UTC()
226+
expiry := time.Now().Add(24 * time.Hour).UTC()
223227

224228
c := serviceClient.NewClient(tableName)
225229
sasUrl, err := c.GetTableSASURL(permissions, start, expiry)

0 commit comments

Comments
 (0)