Tests: Make sure fixtures are valid PHP

Author: sirbrillig

tests/Sniffs/Functions/ClosureFixture.php

@@ -20,14 +20,4 @@ public function hasClosureWithReturn() {
 return true;
 };
 }
-
-public function hasClosureWithOneVoidReturnAndBoolHint() {
-// The next line should report an invalid void return
-$myFunc = function () : bool {
-if (rand(1, 10) > 5) {
-return true;
-}
-return;
-};
-}
 }

tests/Sniffs/Functions/TypeHintSniffTest.php

@@ -40,7 +40,7 @@ public function testTypeHintSniffWithClosures() {
 $warningLines = $helper->getWarningLineNumbersFromFile($phpcsFile);
 $errorLines = $helper->getErrorLineNumbersFromFile($phpcsFile);
 $this->assertEquals([5, 11], $warningLines);
-$this->assertEquals([26], $errorLines);
+$this->assertEquals([], $errorLines);
 }
 
 public function testTypeHintSniffWithInterface() {