Skip to content

Conversation

@dcodeIO
Copy link
Member

@dcodeIO dcodeIO commented Mar 28, 2018

This PR includes the remaining implementations of JavaScript's Math functions, both double (Math) and single (Mathf) precision, ported from musl incl. tests from libc-test.

Still TODO:

  • Implement % and ** based on this
  • JavaScript's pow semantics differ in 1^NaN and 1^Infinity special cases
  • random must be seeded explicitly (seedRandom) before use, as it otherwise would require an import
  • JavaScript's Math.round rounds exact fractional 0.5 towards +inf
  • sin/cos/tan (MaxGraey would like to look into these specifically)
  • At some occasions it might make sense to use built-in copysign etc. (can be postponed)
@dcodeIO dcodeIO changed the title WIP: Even more math Even more math Mar 30, 2018
@dcodeIO dcodeIO merged commit 164f134 into master Mar 30, 2018
@dcodeIO dcodeIO deleted the math branch May 6, 2018 02:39
radu-matei pushed a commit to radu-matei/assemblyscript that referenced this pull request Oct 13, 2020
Bumps [assemblyscript](https://github.com/AssemblyScript/assemblyscript) from 0.14.0 to 0.14.1. - [Release notes](https://github.com/AssemblyScript/assemblyscript/releases) - [Commits](AssemblyScript/assemblyscript@v0.14.0...v0.14.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants